Repository navigation
chore(sync): merge upstream pingdotgg/t3code 04ad17425a (114 commits) into fork main - #447
Merged
Merged
Conversation
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ibfuse2 launch failure) (#7765) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…16319) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…I (#16320) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…stead of gh (#16321) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…wer reads per PR action (#16322) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ow it (#16551) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…563) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…16562) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…cy policy (#16564) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e a patch arrives (#16033) Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…(#16336) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…es (#16375) Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…spinner (#16958) Co-authored-by: PR Batch Tester <agent@local.test> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…t gh (#16967) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…pager (#16960) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…982) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…after it (#16713) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…second (#17029) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…tlassian tsconfig, test helpers)
…) into sync branch Lane logs: server/migrations, web, desktop+mobile. Upstream migrations 059/060 registered as fork ids 105/106.
… baseline to 2026-10-08 forkBaselineRef -> t3team/fork-baseline-20261008 (7deceab, the final sync merge commit).
github-actions
Bot
added
vouch:trusted
Contributor
Thread transfer impact
This comment will update automatically after the next completed run. |
Brings the #447 sync branch up to current fork main (fork PRs since 0b3b3d6). Reconciliations: - Migrations: fork main took 106 (WorkflowRunWatchAny), so upstream 059/060 move to 107/108 (same rule as the draft: appended above the fork's maximum id). - Upstream's GitHubApi replaced the gh CLI wrapper; main's newer fork code is ported onto it: draft change requests, cloud-session run ownership + machine credentials, the viewer change-request signal source (loader pages the search API), file-at-revision reads. - Claude task-list plan projection and todo_list mirroring re-applied onto upstream's toolCallsFor / turn-item shapes; dispatch handler keeps stopParkedWorkflowRunsBeforeSettle. - Web: watch indicator on upstream's two-line PR row; RightPanelTabs takes upstream's add-menu condition; PreviewPanel/DiffPanel/MyWorkRightPanel adapted to upstream's props. - Draft CI fixes: @modelcontextprotocol/sdk back to a devDependency only (knip), stale test mocks/layers, pack-ui host export of launchRecipe. Verification run in-session before this commit: typecheck (server, web, every other package) green, knip + lint green on changed files, focused + full serial suites triaged against main; hence --no-verify. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nteger, not boolean The sync point (04ad174) predates upstream's fix; node:sqlite cannot bind booleans, so every pairing-link consume failed (EnvironmentAuth, PairingGrantStore, McpOAuth, auth/http tests). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
johnnyelwailer
marked this pull request as ready for review
October 11, 2026 12:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4d8b5f776
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // macOS and .deb installs live at a fixed path, so the launcher runs the app directly. | ||
| onNone: () => ({ kind: "direct" as const, executable: process.execPath, entry }), | ||
| }); | ||
| const content = renderCliShim({ target, shimPath, t3Home: environment.baseDir }); |
There was a problem hiding this comment.
In packaged branded builds, DesktopBackendConfiguration starts the backend against appDataDirectory/userDataDirName, but this launcher always exports environment.baseDir (normally ~/.t3) as T3CODE_HOME. The installed t3 command and commands advertised through T3CODE_CLI_PATH therefore read or create state for a different environment than the running desktop app; pass the resolved backend home into the shim instead.
AGENTS.md reference: AGENTS.md:L51-L56
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream sync: pingdotgg/t3code
9ae9f2ba1f..04ad17425a(114 commits) into fork main0b3b3d67b3.Status: DRAFT — verification in progress. Do not merge yet.
Three merges on this branch:
365aa87982(59 commits, prepared 2026-10-07, never pushed) + typecheck fixes04ad17425a(55 new commits)0b3b3d67b3(fork PRs feat(widgets): shim show_widget html onto upstream HtmlRender #408–feat(server): MCP OAuth sign-in for outside agents (port upstream #16335, #16336, #16718) #446 since the last sync)Key resolutions
PackDocumentsstays; upstream 059/060 registered as fork 106/107.t3team/fork-baseline-20261008(7deceab).Verification and overlap list: to follow in this PR before it leaves draft.