Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add base url as parameter #6

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Conversation

BlackDark
Copy link

@gagoar
Copy link
Collaborator

gagoar commented Dec 15, 2022

Hey @BlackDark I think now we are ready for this!

@gagoar gagoar marked this pull request as ready for review December 15, 2022 21:15
@BlackDark
Copy link
Author

Hey @BlackDark I think now we are ready for this!

Hey @gagoar rebased PR and should be good to go.
@jnwng feel free to review + merge :)

@gagoar
Copy link
Collaborator

gagoar commented Dec 19, 2022

The steps are failing because the tokens used in this Repo can't be accessed by you. I will cherry pick your commits and recreate the PR in the base repository.

@gagoar
Copy link
Collaborator

gagoar commented Dec 19, 2022

Can you fix the tests ? these should pass in here for you @BlackDark

@BlackDark
Copy link
Author

Can you fix the tests ? these should pass in here for you @BlackDark

Done was a problem with the mocked input

gagoar added a commit that referenced this pull request Dec 29, 2022
This PR adds baseUrl to the action allowing onPerm GitHub instances to take advantage of the action. 

I've replicated #6 @bBackdark PR to avoid having issues with tokens missing in the workflows.
@gagoar gagoar merged commit 33ba9fd into jnwng:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants