-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to change base url of github #124
Conversation
Hey, I just saw that, would you like to finish this? I see there are some problems with the workflows, I can fix that! |
Hey @BlackDark I've fixed some of the workflows, to make them run correctly when there's a fork, could you rebase with main? thanks! Also please add a description of the use case you are trying to get this feature for? thanks, |
ad1df40
to
b34c214
Compare
Hi @gagoar, thanks for the response. Rebased the branch onto the main. |
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 61 61
Branches 8 8
=========================================
Hits 61 61
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yea, it seems like sadly the DeepSource is failing because the error on the try-catch doesn't have a type. are you familiar with TS to include it in your review? I can wip up a PR fixing that first as well. Also please add a description to the PR when you get a chance. Is very useful to know the use-case you are optimizing for. Thanks again. |
on #124 we seem to have an issue unrelated to the changes that are being made. I decided to type it so the error stops happening. * some upgrades with @typescript-eslint/* that are confusing
Hey @BlackDark I've fixed the issue you see here coming from I can help with the action that uses this package as well so we can release things in tandem. |
b34c214
to
7fda5d9
Compare
So sorry for the really late action. Didn't have much free time to spare. Rebased and updated the description. |
Added new parameter for specifying a different URL for github.
This is useful if a github enterprise instance is hosted and you want to use the code there.
No breaking change.