Fix xgboost_synthetic notebook for Kubeflow 1.1.

* Fairing needs to be upgraded to fairing 1.0.1 Related to GoogleCloudPlatform/kubeflow-distribution#78
jlewi · Jul 10, 2020 · 52f272a · 52f272a
1 parent db27136
commit 52f272a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/xgboost_synthetic/notebook_setup.py b/xgboost_synthetic/notebook_setup.py
@@ -11,7 +11,6 @@
 from pathlib import Path
 
 KFP_PACKAGE = 'https://storage.googleapis.com/ml-pipeline/release/0.1.32/kfp.tar.gz'
-FAIRING_PACKAGE = 'git+git://github.com/kubeflow/fairing.git@9b0d4ed4796ba349ac6067bbd802ff1d6454d015' # pylint: disable=line-too-long
 
 def notebook_setup():
   # Install the SDK
@@ -22,8 +21,6 @@ def notebook_setup():
   subprocess.check_call(["pip3", "install", "--user", "-r", "requirements.txt"])
   logging.info("pip installing KFP %s", KFP_PACKAGE)
   subprocess.check_call(["pip3", "install", "--user", KFP_PACKAGE, "--upgrade"])
-  logging.info("pip installing fairing %s", FAIRING_PACKAGE)
-  subprocess.check_call(["pip3", "install", "--user", FAIRING_PACKAGE])
 
   logging.info("Configure docker credentials")
   subprocess.check_call(["gcloud", "auth", "configure-docker", "--quiet"])

diff --git a/xgboost_synthetic/requirements.txt b/xgboost_synthetic/requirements.txt
@@ -1,6 +1,7 @@
 fire
 gitpython
 google-cloud-storage
+git+git://github.com/kubeflow/fairing.git@v1.0.1
 joblib
 kubeflow-metadata==0.3.1
 numpy