Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run xgboost notebook tests #78

Open
jlewi opened this issue Jul 10, 2020 · 4 comments
Open

Run xgboost notebook tests #78

jlewi opened this issue Jul 10, 2020 · 4 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 10, 2020

Need to setup the notebook tests for xgboost

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.78
area/jupyter 0.68

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

jlewi pushed a commit to jlewi/gcp-blueprints that referenced this issue Jul 10, 2020
@jlewi
Copy link
Contributor Author

jlewi commented Jul 10, 2020

Runs are failing looks like a bug is failing we are missing a trailing ""

 pytest run_notebook_test.py \
    --log-cli-level=info \
    --log-cli-format='%(levelname)s|%(asctime)s|%(pathname)s|%(lineno)d| %(message)s' \
    --timeout=1800 \
    --junitxml=/workspace/artifacts/junit_notebook.xml \
    --notebook_path=/src/notebook-repo/$(inputs.params.notebook-path) \
    --test-target-name=$(inputs.params.test-target-name) \
    --artifacts-gcs=$(inputs.params.notebook-output) \
    --image_file=$(inputs.params.artifacts-gcs)/image.yaml
    --namespace=$(inputs.params.nb-namespace)

jlewi pushed a commit to jlewi/testing that referenced this issue Jul 10, 2020
* The script to run a notebook is missing a trailing slash to indicate
  a continued command.

* Related to GoogleCloudPlatform/kubeflow-distribution#78
jlewi pushed a commit to jlewi/examples that referenced this issue Jul 10, 2020
* Fairing needs to be upgraded to fairing 1.0.1

Related to GoogleCloudPlatform/kubeflow-distribution#78
k8s-ci-robot pushed a commit that referenced this issue Jul 11, 2020
k8s-ci-robot pushed a commit to kubeflow/examples that referenced this issue Jul 11, 2020
k8s-ci-robot pushed a commit to kubeflow/testing that referenced this issue Jul 11, 2020
* The script to run a notebook is missing a trailing slash to indicate
  a continued command.

* Related to GoogleCloudPlatform/kubeflow-distribution#78
@jlewi
Copy link
Contributor Author

jlewi commented Jul 13, 2020

The test is running on master:
Its being reported as a success but an exception is actually occuring.
If you look at the notebook there is a problem submitting pipelines
https://storage.googleapis.com/kubernetes-jenkins/logs/kubeflow-gcp-blueprints-periodic-master/1282789521116631041/artifacts/junit_xgboost-notebook/xgboost_test

jlewi pushed a commit to jlewi/gcp-blueprints that referenced this issue Jul 13, 2020
k8s-ci-robot pushed a commit that referenced this issue Jul 13, 2020
…on v1.1-branch. #79: Enable xgboost test. (#81)

related to #78
@jtfogarty
Copy link

/priority p1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants