Fixes return types for the before and after query methods to match the documentation #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkepps
force-pushed
the
fix-after-return-type
branch
from
0221d3c
to
aedf23d
Compare
|
@davidgoli This PR addresses the comment you left on #462, and is slightly more comprehensive than #524 |
3 tasks
davidgoli
approved these changes
Feb 10, 2023
ghost
mentioned this pull request
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #560
Thanks for contributing to
rrule!To submit a pull request, please verify that you have done the following:
mastercommitaddressing