Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return type for RRule.after #560

Open
4 of 7 tasks
jkepps opened this issue Nov 25, 2022 · 1 comment
Open
4 of 7 tasks

Incorrect return type for RRule.after #560

jkepps opened this issue Nov 25, 2022 · 1 comment

Comments

@jkepps
Copy link
Contributor

jkepps commented Nov 25, 2022

RRule.after docs say that it returns Date or null, but the function definition specifies only Date. The function will return null if there are no dates in the recurrence after the given parameter, so the function does indeed return Date or null. The function definition should be updated to specify the correct return type.

The repro steps are fairly straightforward. Instantiate a new rrule object with a recurrence in the past. Invoke the after method with a date that's in the future. The function will return null.

  • Verify that you've looked through existing issues for duplicates before
    creating a new one
  • Code sample reproducing the issue. Be sure to include all input values you
    are using such as the exact RRule string and dates.
  • Expected output
  • Actual output
  • The version of rrule you are using
  • Your operating system
  • Your local timezone (run $ date from the command line
    of the machine showing the bug)
@ghost
Copy link

ghost commented Sep 13, 2024

I believe this should have been closed after #561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant