Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mark bridge unhealthy based on restart requests from endpoints #1210

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
+225 −104
Open

feat: Mark bridge unhealthy based on restart requests from endpoints #1210

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
57542f2
ref: Simplify code, order alphabetically.
bgrozev Feb 12, 2025
454365e
feat: Keep track of number of endpoints on each Bridge.
bgrozev Feb 12, 2025
7fd30bb
feat: Mark bridge unhealthy based on restart requests from endpoints
bgrozev Feb 12, 2025
2d64468
squash: Rename val, add debug state.
bgrozev Feb 12, 2025
f825ce9
log: Log if endpoints count becomes negative.
bgrozev Feb 12, 2025
d39129b
squash: Increase window size.
bgrozev Feb 13, 2025
9d8735d
feat: Add per-bridge metrics for endpoint and restart requests.
bgrozev Feb 19, 2025
b1670bd
ref: Cleanup comment formatting.
bgrozev Feb 20, 2025
088adcb
ref: Rename Bridge.stress to correctedStress.
bgrozev Feb 20, 2025
9cb2ea4
feat: Penalize stress instead of marking as non-operational.
bgrozev Feb 20, 2025
11d9ed4
fix: Don't update metrics after removed.
bgrozev Feb 20, 2025
61e2dc1
feat: Add metric for failing ICE.
bgrozev Feb 20, 2025
a6a4777
squash: Remove unused import.
bgrozev Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
log: Log if endpoints count becomes negative.
  • Loading branch information
@bgrozev
bgrozev committed Feb 12, 2025
commit f825ce9f1c99c8e42cfc38ae1bcd7338f1f519a3
4 changes: 4 additions & 0 deletions jicofo-selector/src/main/kotlin/org/jitsi/jicofo/bridge/Bridge.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,10 @@ class Bridge @JvmOverloads internal constructor(
fun endpointRemoved() = endpointsRemoved(1)
fun endpointsRemoved(count: Int) {
endpoints.addAndGet(-count)
if (endpoints.get() < 0) {
logger.error("Removed more endpoints than were allocated. Resetting to 0.", Throwable())
endpoints.set(0)
}
}
fun endpointRequestedRestart() {
endpointRestartRequestRate.update(1)
Expand Down