Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mark bridge unhealthy based on restart requests from endpoints #1210

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Feb 12, 2025

  • ref: Simplify code, order alphabetically.
  • feat: Keep track of number of endpoints on each Bridge.
  • feat: Mark bridge unhealthy based on restart requests from endpoints

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 30.64516% with 43 lines in your changes missing coverage. Please review.

Project coverage is 26.51%. Comparing base (7431511) to head (7fd30bb).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
.../src/main/kotlin/org/jitsi/jicofo/bridge/Bridge.kt 21.21% 26 Missing ⚠️
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 0.00% 10 Missing ⚠️
...i/jicofo/bridge/colibri/ColibriV2SessionManager.kt 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1210      +/-   ##
============================================
- Coverage     27.27%   26.51%   -0.77%     
+ Complexity      489      466      -23     
============================================
  Files           125      125              
  Lines          8084     8162      +78     
  Branches       1121     1136      +15     
============================================
- Hits           2205     2164      -41     
- Misses         5597     5712     +115     
- Partials        282      286       +4     
Files with missing lines Coverage Δ
...ain/kotlin/org/jitsi/jicofo/bridge/BridgeConfig.kt 93.39% <100.00%> (+2.21%) ⬆️
...n/kotlin/org/jitsi/jicofo/bridge/BridgeSelector.kt 60.62% <ø> (-0.14%) ⬇️
...tsi/jicofo/bridge/colibri/ColibriSessionManager.kt 0.00% <ø> (ø)
...i/jicofo/bridge/colibri/ColibriV2SessionManager.kt 0.00% <0.00%> (ø)
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 40.48% <0.00%> (-2.07%) ⬇️
.../src/main/kotlin/org/jitsi/jicofo/bridge/Bridge.kt 65.35% <21.21%> (-7.55%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54138e0...7fd30bb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants