Skip to content

Commit

Permalink
Merge pull request kubernetes#10 from jimmidyson/strip-makefile
Browse files Browse the repository at this point in the history
Update linker flags and strip binaries to shrink download
  • Loading branch information
jimmidyson authored Jul 14, 2016
2 parents e5c9777 + 202b498 commit 6bc1225
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ BUILD_OS := $(shell uname -s)

# Set the version information for the Kubernetes servers
K8S_VERSION_LDFLAGS := $(shell $(PYTHON) hack/get_k8s_version.py 2>&1)
MINIKUBE_LDFLAGS := -X github.com/jimmidyson/minishift/pkg/version.version=$(VERSION)
MINIKUBE_LDFLAGS := $(K8S_VERSION_LDFLAGS) -X github.com/jimmidyson/minishift/pkg/version.version=$(VERSION) -s -w -extldflags '-static'

MKGOPATH := mkdir -p $(shell dirname $(GOPATH)/src/$(REPOPATH)) && ln -s -f $(shell pwd) $(GOPATH)/src/$(REPOPATH)

Expand Down Expand Up @@ -79,7 +79,7 @@ $(GOPATH)/bin/gh-release:
.PHONY: gendocs
gendocs: $(shell find cmd) pkg/minikube/cluster/assets.go
$(MKGOPATH)
cd $(GOPATH)/src/$(REPOPATH) && go run -ldflags="-X github.com/jimmidyson/minishift/pkg/version.version=$(shell cat VERSION)" gen_help_text.go
cd $(GOPATH)/src/$(REPOPATH) && go run -ldflags="$(MINIKUBE_LDFLAGS)" gen_help_text.go

.PHONY: release
release: clean deploy/iso/minishift.iso test $(GOPATH)/bin/gh-release cross
Expand Down
2 changes: 0 additions & 2 deletions cmd/minikube/cmd/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ func runStart(cmd *cobra.Command, args []string) {
VMDriver: vmDriver,
}

fmt.Println(config.DiskSize)

var host *host.Host
start := func() (err error) {
host, err = cluster.StartHost(api, config)
Expand Down

0 comments on commit 6bc1225

Please sign in to comment.