Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support serviceaccounts #10

Closed
sebgoa opened this issue Apr 20, 2016 · 4 comments
Closed

Support serviceaccounts #10

sebgoa opened this issue Apr 20, 2016 · 4 comments

Comments

@sebgoa
Copy link

sebgoa commented Apr 20, 2016

Without them DNS addon won't work (and lots of other things as well)
It is not an issue if we keep relying on weave in localkube.
@luxas
Copy link
Member

luxas commented Apr 20, 2016

ServiceAccount should be present.
Weave should not be a dep, we'll manage without it

@dlorenc
Copy link
Contributor

dlorenc commented Apr 20, 2016

This is how hyperkube sets up service accounts:
https://github.com/kubernetes/kubernetes/blob/master/cluster/images/hyperkube/setup-files.sh

They generate tokens using urandom and pass them into the api server via --token-auth-file

@luxas
Copy link
Member

luxas commented Apr 20, 2016

Yes, we're using easyrsa for certificate creation
However, when we have go, we should do something like this: redspread/localkube#50

@dlorenc dlorenc mentioned this issue Apr 27, 2016
Closed
@dlorenc dlorenc mentioned this issue May 6, 2016
Merged
@dlorenc
Copy link
Contributor

dlorenc commented May 9, 2016

This should be working now with #48.

@dlorenc dlorenc closed this as completed May 9, 2016
jimmidyson added a commit to jimmidyson/minikube that referenced this issue Sep 2, 2016
@jimmidyson
Merge pull request kubernetes#10 from jimmidyson/strip-makefile
6bc1225 
Update linker flags and strip binaries to shrink download
zregvart added a commit to zregvart/minikube that referenced this issue May 7, 2019
@zregvart
Fix registry addon ReplicationController template
40da502 
Running the `minikube addons enable registry` yields `registry was successfully enabled` but no `registry` Pod ends up being run.

I've narrowed it down to this `env` entry not being quoted.

Logs from `kube-addon-manager-minikube` Pod show this error:

```
Error from server (BadRequest): error when creating "/etc/kubernetes/addons/registry-rc.yaml": ReplicationController in version "v1" cannot be handled as a ReplicationController: v1.ReplicationController.Spec: v1.ReplicationControllerSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found t, error found in kubernetes#10 byte of ...|,"value":true}],"ima|..., bigger context ...|"name":"REGISTRY_STORAGE_DELETE_ENABLED","value":true}],"image":"registry.hub.docker.com/library/reg|...
```
@e-dard e-dard mentioned this issue Oct 11, 2019
Closed
This was referenced Dec 4, 2019
Closed
Closed
@nitinmuteja nitinmuteja mentioned this issue Apr 9, 2020
Closed
@vivientouvier vivientouvier mentioned this issue Jan 20, 2022
Closed
klaases pushed a commit to klaases/minikube that referenced this issue Apr 14, 2022
@sharifelgamal
Merge pull request kubernetes#10 from sharifelgamal/v0.0.4
19aa2f5 
Bump gcp-auth-webhook image version to v0.0.4
@uniorder uniorder mentioned this issue Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dlorenc @sebgoa @luxas