Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/formater on off #323

Merged

Conversation

clementdessoude
Copy link
Contributor

@clementdessoude clementdessoude commented Dec 8, 2019

Hi @nonomoho!

I tried to fix the conflicts between your branch and master. Can you have a look and tell me if you think it is ok?

Fix #287

@nonomoho
Copy link
Member

nonomoho commented Dec 9, 2019

LGTM! Thanks for the help on it 😊

@clementdessoude clementdessoude merged commit 01740e0 into jhipster:master Dec 9, 2019
@clementdessoude clementdessoude deleted the feature/formater-on-off branch December 9, 2019 21:37
@clementdessoude clementdessoude mentioned this pull request Dec 9, 2019
@nonomoho
Copy link
Member

@pascalgrimaud
Copy link
Member

approuved @nonomoho
Don't forget yours @clementdessoude

@clementdessoude
Copy link
Contributor Author

Bounty claimed too 😃! https://opencollective.com/generator-jhipster/expenses/12622

@pascalgrimaud
Copy link
Member

just approuved @clementdessoude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle @formatter:off and @formatter:on ?
3 participants