Formatter off on #289
Closed
Formatter off on #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonomoho
force-pushed
the
formatter-off-on
branch
from
c309f63
to
f744c9f
Compare
|
good job @nonomoho ! |
clementdessoude
requested changes
Nov 13, 2019
There was a problem hiding this comment.
LGTM ! Thanks @nonomoho !
Just two additionals comments:
- it would be great to find crystal clear names for the formatter-on-off functions to distinguish them from the prettier-ignore ones. Maybe separate them in the code and add jsdoc ?
- in the same idea, we could try to call only one method in
packages/java-parser/src/index.jswhich contains the logic regarding ignore-comments (prettier-ignore and formatter:(on|off)). Same inpackages/java-parser/src/parser.js: it would be clearer IMO to just call ashouldIgnorefunction in the parser file, which would then call a shouldIgnoreOffOn/PrettierIgnore or something like that
|
Would it be possible to add some tests at some other places than just before classes definition ? Before methods, binary operations and so on |
nonomoho
force-pushed
the
formatter-off-on
branch
from
aa7ff99
to
393ee63
Compare
|
Closed with #323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #287