New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whirl linting errors #39

Closed

jh3y opened this issue Oct 7, 2019 · 0 comments · Fixed by #40

Labels

Owner

jh3y commented Oct 7, 2019

Describe the bug

There are some linting errors currently with the whirls
Let's fix the linting errors and make sure that CI also does this linting 👍

To Reproduce
Steps to reproduce the behavior:

Clone the repo
Install deps
Run yarn lint:whirls

Expected behavior

There should be no linting errors

Solution

Fix the linting errors in relevant src
Update yarn lint in package.json so it also runs yarn lint:whirls in addition to eslint.
Maybe move eslint usage to yarn lint:scripts?

The text was updated successfully, but these errors were encountered:

jh3y added the Hacktoberfest label

jh3y added a commit that referenced this issue


          fix: resolve #39 by fixing lint errors and updating CI

f8b789e

jh3y mentioned this issue

fix: resolve #39 by fixing lint errors and updating CI #40

Merged

2 tasks

jh3y closed this as completed in #40

jh3y added a commit that referenced this issue


          fix: resolve #39 by fixing lint errors and updating CI (#40)

bd49bf6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment