Skip to content

Commit

Permalink
fix: resolve #39 by fixing lint errors and updating CI (#40)
Browse files Browse the repository at this point in the history
  • Loading branch information
jh3y authored Oct 8, 2019
1 parent 466ba0c commit bd49bf6
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 6 deletions.
5 changes: 4 additions & 1 deletion .stylelintrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
{
"extends": "stylelint-config-recommended-scss"
"extends": "stylelint-config-recommended-scss",
"rules": {
"no-descending-specificity": [true, {"severity": "warning"}]
}
}
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,14 @@
"postpublish": "rm -rf dist css sass",
"start": "react-scripts start",
"build": "react-scripts build",
"test": "npm run lint",
"test": "yarn lint",
"eject": "react-scripts eject",
"add-whirl": "node utils/add-whirl",
"publish-package": "export FOR_PACKAGE=true && mkdir -pv css && cp -rf src/whirls sass && node utils/publish",
"publish-css": "export FOR_PACKAGE=false && mkdir -pv dist/css && cp -rf src/whirls dist/sass && cp README.md dist/README.md && node utils/publish",
"precommit": "lint-staged",
"lint": "eslint src",
"lint": "yarn lint:scripts && yarn lint:whirls",
"lint:scripts": "eslint src",
"lint:whirls": "stylelint 'src/**/*.scss' --syntax scss"
},
"lint-staged": {
Expand Down
2 changes: 1 addition & 1 deletion src/whirls/box-spin.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ $size: 50px;
left: 50%;
top: 50%;
margin-left: -25px;
margin-top: -25pxpx;
margin-top: -25px;
}
}
2 changes: 1 addition & 1 deletion src/whirls/in-and-out.scss
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ $duration: 1s;
animation: in-and-out-children $duration infinite ease;
}
}

&:nth-of-type(2) {
--multiplier: 2;
animation: in-and-out-two $duration infinite ease both;
Expand All @@ -68,6 +67,7 @@ $duration: 1s;
}
}


}

div div {
Expand Down
2 changes: 1 addition & 1 deletion src/whirls/square-of-dots.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* @author jh3y
*/

$dot-color: var(--primary);;
$dot-color: var(--primary);
$dot-size: 10px;
$dot-margin: 5px;
$first: $dot-size + $dot-margin;
Expand Down

0 comments on commit bd49bf6

Please sign in to comment.