Nat minor2 #60
Merged
Nat minor2 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcanemagus
reviewed
Nov 4, 2019
postgresqltuner.pl
Outdated
| print_report_ok("huge_pages=on, therefore PostgreSQL needs Huge Pages"); | ||
| } | ||
| elsif (get_setting('huge_pages') eq 'try') { | ||
| print_report_bad("huge_pages=on, therefore PostgreSQL will try to use Huge Pages, if they are enabled"); |
There was a problem hiding this comment.
You have try set as a print_report_bad level message, while completely disabled is only medium advice.
If anything on should be a print_report_warn, since the server will completely fail to start if it has no available huge pages.
There was a problem hiding this comment.
You are right, thank you!
|
Thanks again ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More janitor-related work, added the --nocolor option, various comments