huge_pages only accepts 'on'

[Arcanemagus]

postgresqltuner/postgresqltuner.pl

Lines 607 to 612 in a12c432

	if (get_setting('huge_pages') eq 'on') {
	print_report_ok("huge_pages enabled in PostgreSQL");
	} else {
	print_report_bad("huge_pages disabled in PostgreSQL");
	add_advice("hugepages","medium","Enable huge_pages in PostgreSQL to consume system Huge Pages");
	}

This bit of code doesn't seem to understand the values for this setting, as described in the documentation for huge_pages the default value of this setting is try, which will use them if available but won't fail to start if they aren't. The recommended value of on will actually prevent the server from starting if there aren't enough pages available!

This should only warn if the value has been explicitly set to off.

[natmaka]

Indeed. I fixed it.

[jfcoz]

Thanks