-
-
Notifications
You must be signed in to change notification settings - Fork 28
chore: update subprocessor list #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,97 +1,144 @@ | ||||||
| import { CheckIcon, XMarkIcon } from '@heroicons/react/20/solid'; | ||||||
| import LastUpdated from '../../components/LastUpdated'; | ||||||
| import Layout from '../../components/layouts/Layout'; | ||||||
| import { ROUTES } from '../../utils/environment'; | ||||||
|
|
||||||
| const YesIcon = <CheckIcon className="h-6 w-6 text-green-600" aria-hidden="true" />; | ||||||
| const NoIcon = <XMarkIcon className="h-6 w-6 text-gray-600" aria-hidden="true" />; | ||||||
|
|
||||||
| const webSubProcessors = [ | ||||||
| { name: 'BackBlaze', function: 'Asset storage', location: 'US', optional: 'No', extension: false }, | ||||||
| { name: 'BetterStack', function: 'Server Logging and Status Page', location: 'US', optional: 'No', extension: false }, | ||||||
| { name: 'Amplitude', function: 'Telemetry', location: 'US', optional: 'Yes, opt-in via cookie consent banner.', extension: false }, | ||||||
| { name: 'Cloudflare', function: 'Infrastructure', location: 'US', optional: 'No', extension: false }, | ||||||
| { | ||||||
| name: 'BackBlaze', | ||||||
| function: 'Object storage to store database backups', | ||||||
| location: 'US', | ||||||
| optional: NoIcon, | ||||||
| extension: false, | ||||||
| desktop: false, | ||||||
| salesforceCanvas: false, | ||||||
| }, | ||||||
| { | ||||||
| name: 'BetterStack', | ||||||
| function: 'Server logging; alerts; incident management and status page', | ||||||
| location: 'US', | ||||||
| optional: NoIcon, | ||||||
| extension: false, | ||||||
| desktop: false, | ||||||
| salesforceCanvas: false, | ||||||
| }, | ||||||
| { | ||||||
| name: 'Amplitude', | ||||||
| function: 'Telemetry', | ||||||
| location: 'US', | ||||||
| optional: 'Yes, opt-in via cookie consent banner.', | ||||||
|
||||||
| optional: 'Yes, opt-in via cookie consent banner.', | |
| optional: YesIcon, |
Copilot
AI
Jan 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to Amplitude, the Google Cloud entry uses a string value for the optional field instead of YesIcon component. This creates an inconsistent data structure where some entries have React components and others have strings in the same field. This should be changed to YesIcon for consistency with the table's visual design.
| optional: 'Yes', | |
| optional: YesIcon, |
Copilot
AI
Jan 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Google Ads entry uses a string value for the optional field, creating the same inconsistency as Amplitude and Google Cloud entries. For consistent rendering and visual design, this should use YesIcon instead of the string "Yes, opt-in via cookie consent banner."
| optional: 'Yes, opt-in via cookie consent banner.', | |
| optional: YesIcon, |
Copilot
AI
Jan 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence is grammatically incorrect. "Our web-based application other platforms" is missing a connector word. It should be "Our web-based application and other platforms" to properly connect the two parts of the sentence.
| This page provides a list of sub-processors that Jetstream uses to provide services to our customers. Our web-based application | |
| This page provides a list of sub-processors that Jetstream uses to provide services to our customers. Our web-based application and |
Copilot
AI
Jan 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table structure renders all entries with YesIcon in the "Web" column (line 134), but the data structure doesn't include a web property. This means all subprocessors are displayed as available for Web, which may not be accurate. Consider adding a web property to each entry in the webSubProcessors array or using a different approach to indicate which platforms each subprocessor supports.
Copilot
AI
Jan 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented-out code contains a JSX syntax error. The curly braces are incorrectly placed around YesIcon and NoIcon, which are already variables. It should be either {YesIcon} or {NoIcon} without the extra braces. However, since this is commented out code that appears to be for a future Salesforce Canvas column, consider removing it entirely to keep the codebase clean, or fix the syntax if it will be uncommented soon.
| {/* <td className="p-3">{item.salesforceCanvas ? {YesIcon} : {NoIcon}}</td> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons are missing appropriate accessibility attributes. While aria-hidden is set to true, screen reader users won't receive any information about whether a feature is optional or not. Consider adding appropriate aria-label attributes to communicate this information to assistive technologies, or ensure the table cell has additional text content that screen readers can access.