chore: update subprocessor list #1496
Conversation
Remove honeycomb Improve table layout and formatting
There was a problem hiding this comment.
Pull request overview
This PR removes Honeycomb as a subprocessor and improves the subprocessor list table with better formatting and a more comprehensive platform breakdown. The changes include removing Honeycomb environment variables and configuration, consolidating the subprocessor table into a single unified view showing availability across different platforms (Web, Browser Extension, Desktop), and updating the last modified date to January 4, 2026.
Key changes:
- Removed Honeycomb environment configuration and production settings
- Refactored subprocessor table from two separate tables to one consolidated table with platform columns
- Enhanced subprocessor descriptions and added visual icons for optional/required status
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| libs/api-config/src/lib/env-config.ts | Removed Honeycomb-related environment variables (HONEYCOMB_ENABLED and HONEYCOMB_API_KEY) |
| apps/landing/pages/subprocessors/index.tsx | Removed Honeycomb entry, restructured table to show platform availability with visual icons, improved descriptions, and added sorting |
| apps/landing/components/LastUpdated.tsx | Added 2026 to the accepted year values |
| apps/api/.env.production | Removed HONEYCOMB_ENABLED configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <td className="border border-gray-300 p-3">{item.function}</td> | ||
| <td className="border border-gray-300 p-3">{item.location}</td> | ||
| <td className="border border-gray-300 p-3">{item.optional}</td> | ||
| <td className="border border-gray-300 p-3">{YesIcon}</td> |
There was a problem hiding this comment.
The table structure renders all entries with YesIcon in the "Web" column (line 134), but the data structure doesn't include a web property. This means all subprocessors are displayed as available for Web, which may not be accurate. Consider adding a web property to each entry in the webSubProcessors array or using a different approach to indicate which platforms each subprocessor supports.
| <p className="mb-2 pl-2"> | ||
| This page provides a list of sub-processors that Jetstream uses to provide services to our customers. Our web-based application and | ||
| Browser Extension have a different set of processors and different opt-in/opt-out capabilities. | ||
| This page provides a list of sub-processors that Jetstream uses to provide services to our customers. Our web-based application |
There was a problem hiding this comment.
The sentence is grammatically incorrect. "Our web-based application other platforms" is missing a connector word. It should be "Our web-based application and other platforms" to properly connect the two parts of the sentence.
| This page provides a list of sub-processors that Jetstream uses to provide services to our customers. Our web-based application | |
| This page provides a list of sub-processors that Jetstream uses to provide services to our customers. Our web-based application and |
| name: 'Amplitude', | ||
| function: 'Telemetry', | ||
| location: 'US', | ||
| optional: 'Yes, opt-in via cookie consent banner.', |
There was a problem hiding this comment.
The Amplitude entry has inconsistent data structure. While other entries use either NoIcon or YesIcon for the optional field, this entry uses a string. This inconsistency will cause rendering issues since NoIcon and YesIcon are React components (CheckIcon/XMarkIcon), but this will render the string directly. For consistency and proper rendering, consider using YesIcon and adding a tooltip or note elsewhere if additional context is needed.
| optional: 'Yes, opt-in via cookie consent banner.', | |
| optional: YesIcon, |
| location: 'US', | ||
| optional: 'File storage is opt-in, used if you use Google Drive to save and read files.', | ||
| extension: true, | ||
| optional: 'Yes', |
There was a problem hiding this comment.
Similar to Amplitude, the Google Cloud entry uses a string value for the optional field instead of YesIcon component. This creates an inconsistent data structure where some entries have React components and others have strings in the same field. This should be changed to YesIcon for consistency with the table's visual design.
| optional: 'Yes', | |
| optional: YesIcon, |
| name: 'Google Ads', | ||
| function: 'Analytics', | ||
| location: 'US', | ||
| optional: 'Yes, opt-in via cookie consent banner.', |
There was a problem hiding this comment.
The Google Ads entry uses a string value for the optional field, creating the same inconsistency as Amplitude and Google Cloud entries. For consistent rendering and visual design, this should use YesIcon instead of the string "Yes, opt-in via cookie consent banner."
| optional: 'Yes, opt-in via cookie consent banner.', | |
| optional: YesIcon, |
| <td className="border border-gray-300 p-3">{YesIcon}</td> | ||
| <td className="border border-gray-300 p-3">{item.extension ? YesIcon : NoIcon}</td> | ||
| <td className="border border-gray-300 p-3">{item.desktop ? YesIcon : NoIcon}</td> | ||
| {/* <td className="p-3">{item.salesforceCanvas ? {YesIcon} : {NoIcon}}</td> */} |
There was a problem hiding this comment.
The commented-out code contains a JSX syntax error. The curly braces are incorrectly placed around YesIcon and NoIcon, which are already variables. It should be either {YesIcon} or {NoIcon} without the extra braces. However, since this is commented out code that appears to be for a future Salesforce Canvas column, consider removing it entirely to keep the codebase clean, or fix the syntax if it will be uncommented soon.
| {/* <td className="p-3">{item.salesforceCanvas ? {YesIcon} : {NoIcon}}</td> */} |
| const YesIcon = <CheckIcon className="h-6 w-6 text-green-600" aria-hidden="true" />; | ||
| const NoIcon = <XMarkIcon className="h-6 w-6 text-gray-600" aria-hidden="true" />; |
There was a problem hiding this comment.
The icons are missing appropriate accessibility attributes. While aria-hidden is set to true, screen reader users won't receive any information about whether a feature is optional or not. Consider adding appropriate aria-label attributes to communicate this information to assistive technologies, or ensure the table cell has additional text content that screen readers can access.
| const YesIcon = <CheckIcon className="h-6 w-6 text-green-600" aria-hidden="true" />; | |
| const NoIcon = <XMarkIcon className="h-6 w-6 text-gray-600" aria-hidden="true" />; | |
| const YesIcon = ( | |
| <CheckIcon | |
| className="h-6 w-6 text-green-600" | |
| role="img" | |
| aria-label="Optional feature" | |
| /> | |
| ); | |
| const NoIcon = ( | |
| <XMarkIcon | |
| className="h-6 w-6 text-gray-600" | |
| role="img" | |
| aria-label="Required feature" | |
| /> | |
| ); |
fixed issue in data retention where log storage was incorrect we stated in other places within the document that our retention was 1 year, fixed for accuracy and consistency Also added notice that non-material changes
Remove honeycomb
Improve table layout and formatting