Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardwired top-level backoff #51

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Remove hardwired top-level backoff #51

merged 1 commit into from
Nov 26, 2018

Conversation

bartelink
Copy link
Collaborator

EventStore/EventStore#38 introduced a hardwired backoff as a way to achieve feature parity with an existing implementation, as a way of punting on where such a backoff should live.

Given the fact that the implementation work in EventStore/EventStore#42 has made it clear that a cleaner solution will be possible with Equinox.Cosmos, this PR makes the backoffs pluggable so that one can plug in a hardwired workaround for EventStore/EventStore-Client-Dotnet#312 in the absence of a more appropriate soltuion in any application context.

And, yes, I'd love for someone to clean up the policy such that the way one specifies the exception, max retries and backoffs is much cleaner and discoverable than this :(

@bartelink bartelink merged commit 838e332 into master Nov 26, 2018
@bartelink bartelink deleted the backoffs-pluggable branch November 26, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant