Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop node 8 support #9423

Merged
merged 19 commits into from
May 2, 2020
Merged

chore: drop node 8 support #9423

merged 19 commits into from
May 2, 2020

Conversation

Connormiha
Copy link
Contributor

@Connormiha Connormiha commented Jan 18, 2020 •
edited
Loading

Summary

Node v8.x stopped support since 1 january 2020. https://github.com/nodejs/Release
I made PR to master because master already has breaking changes since last release(24.9).

Test plan

Node 10 supports s flag for RegExp out the box. So with changing babel env it works without any transfromation/polyfills. It changed behavior for prettyFormat with dotAll flag in existed snapshots.

For regexp `/abc/gsy`:
Before:
/abc/gy
After:
/abc/gsy

@codecov-io
Copy link

codecov-io commented Jan 18, 2020 •
edited
Loading

Codecov Report

Merging #9423 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9423      +/-   ##
==========================================
+ Coverage   64.09%   64.11%   +0.02%     
==========================================
  Files         292      291       -1     
  Lines       12451    12449       -2     
  Branches     3070     3071       +1     
==========================================
+ Hits         7980     7982       +2     
+ Misses       3824     3822       -2     
+ Partials      647      645       -2
Impacted Files Coverage Δ
...ges/jest-config/src/readConfigFileAndSetRootDir.ts 0.00% <0.00%> (ø)
packages/jest-environment-node/src/index.ts 56.41% <ø> (+2.75%) ⬆️
packages/expect/src/utils.ts 96.22% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a15e9...332ba5f. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Jan 18, 2020

We'll be keeping support for node 8 in Jest 25. This'll be nice for 26, though, thanks!

@SimenB
Copy link
Member

SimenB commented Feb 13, 2020

Note to self when landing this - we should set minimum version of node to 10.14.2 so #9538 is fixed

@clydin
Copy link

clydin commented Feb 27, 2020

The supports-color dependency on jest-worker can also be dropped when this happens. Node.js provides native support now.
Docs: https://nodejs.org/api/tty.html#tty_writestream_getcolordepth_env
Implementation: https://github.com/nodejs/node/blob/v10.x/lib/internal/tty.js#L72

@SimenB SimenB added this to the Jest 26 milestone Apr 23, 2020
@SimenB
Copy link
Member

SimenB commented May 2, 2020

@clydin wanna open up a PR with that? I'll land this one as soon as CI is green

@SimenB SimenB changed the title Drop node 8 support from babel and ci chore: drop node 8 support May 2, 2020
@SimenB SimenB merged commit 56782b9 into jestjs:master May 2, 2020
@SimenB SimenB mentioned this pull request May 2, 2020
Merged
jeysal added a commit to jeysal/jest that referenced this pull request May 2, 2020
@jeysal
Merge remote-tracking branch 'upstream/master' into circus-add-test-w…
73b95bc 
…hile-running

* upstream/master: (331 commits)
  chore: update ts-eslint (jestjs#9953)
  Updated config docs with default transform value (jestjs#8583)
  Update jest-phabricator documentation (jestjs#8662)
  chore: remove dependency on `realpath-native` (jestjs#9952)
  chore: bump dated dependencies (jestjs#9951)
  chore: another try at fixing test-utils dependency
  chore: update lockfile due to beta release
  chore: move changelog entry and fix tets utils dependency
  Fix time duration formatting as per SI (jestjs#9765)
  v26.0.0-alpha.0
  chore: run some jsdom tests in leak check (jestjs#9938)
  chore: upgrade chalk to v4 (jestjs#9752)
  feat: upgrade to JSDOM 16 (jestjs#9606)
  chore: remove checks for compileFunction (jestjs#9949)
  chore: drop node 8 support  (jestjs#9423)
  Remove leftover `providesModuleNodeModules` (jestjs#9948)
  [BREAKING] Pojer -> Nakazawa
  chore: revert lockfile changes from 2b32fe6
  chore: move changelog entry and fix lint
  Remove `providesModuleNodeModules` from Jest. (jestjs#9583)
  ...
@y-lohse y-lohse mentioned this pull request May 15, 2020
Merged
hamzahamidi added a commit to hamzahamidi/prettier-eslint that referenced this pull request May 22, 2020
@hamzahamidi
chore: downgrade to Jest 25
2b929c2 
Jest 26 dropped node 8 support
jestjs/jest#9423
hamzahamidi added a commit to prettier/prettier-eslint that referenced this pull request May 22, 2020
@hamzahamidi
chore(deps): update dependencies (#338)
29e9d1e 
### dependencies

* "@typescript-eslint/parser": "^3.0.0"
* "eslint": "^6.8.0"
* "typescript": "^3.9.3"
* "vue-eslint-parser": "~7.1.0"

### devDependencies

* "ajv": "^6.12.2"
* "babel-jest": "^25.0.0"
* "jest": "^25.0.0"
* "jest-cli": "^25.0.0"
* "prettier-eslint-cli": "^5.0.0"

Jest 26 dropped node 8 support
jestjs/jest#9423
@mariusbackes mariusbackes mentioned this pull request Nov 23, 2020
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
Jest 26
Development

Successfully merging this pull request may close these issues.
5 participants
@Connormiha @codecov-io @SimenB @clydin @facebook-github-bot