-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jest-phabricator documentation #8662
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #8662 +/- ##
=======================================
Coverage 63.42% 63.42%
=======================================
Files 274 274
Lines 11385 11385
Branches 2771 2771
=======================================
Hits 7221 7221
Misses 3547 3547
Partials 617 617 Continue to review full report at Codecov.
|
@scotthovestadt could you review this? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…hile-running * upstream/master: (331 commits) chore: update ts-eslint (jestjs#9953) Updated config docs with default transform value (jestjs#8583) Update jest-phabricator documentation (jestjs#8662) chore: remove dependency on `realpath-native` (jestjs#9952) chore: bump dated dependencies (jestjs#9951) chore: another try at fixing test-utils dependency chore: update lockfile due to beta release chore: move changelog entry and fix tets utils dependency Fix time duration formatting as per SI (jestjs#9765) v26.0.0-alpha.0 chore: run some jsdom tests in leak check (jestjs#9938) chore: upgrade chalk to v4 (jestjs#9752) feat: upgrade to JSDOM 16 (jestjs#9606) chore: remove checks for compileFunction (jestjs#9949) chore: drop node 8 support (jestjs#9423) Remove leftover `providesModuleNodeModules` (jestjs#9948) [BREAKING] Pojer -> Nakazawa chore: revert lockfile changes from 2b32fe6 chore: move changelog entry and fix lint Remove `providesModuleNodeModules` from Jest. (jestjs#9583) ...
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The example reference is for an older version of Phabricator, as ArcanistBaseUnitTestEngine was removed. Also adds an example of using it with ArcanistConfigurationDrivenUnitTestEngine, which lets you run multiple types of unit test engines.
Furthermore, it adds a list of files to the --findRelatedTests option, which is required.
Test plan
I modified the plugin on my local setup and made sure it works.