chore: update jsdom to v26.0.0

[andreibereczki]

Summary

Increased version of jsdom to ^26.0.0.
#15325
#15217
CVE-2024-37890

Test plan

yarn add jsdom@26.0.0
yarn add @types/jsdom@21.1.7
Not a big deal.

22 tests are failing > but they are failing for me on main as well. No additional tests failed after the change.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: andreibereczki / name: Andrei Bereczki (b030790)

[netlify]

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	b030790
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/6834fd56170b8d0008cb67f9
😎 Deploy Preview	https://deploy-preview-15473--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Smrtnyk]

#15417
weren't there already multiple PRs to update jsdom?

[andreibereczki]

#15417 weren't there already multiple PRs to update jsdom?

There were. And now there's this as well: #15461

[andreibereczki]

Can anyone help with the e2e snapshot tests? <3

I've never done snapshot testing before and don't know how to fix the issues.

[jeremy-daley-kr]

Can anyone help with the e2e snapshot tests? <3

I've never done snapshot testing before and don't know how to fix the issues.

@andreibereczki Are you currently blocked on this? I can't see the failure locally.

[GavinMeierSonos]

Just pointing out Node 16 support was dropped in jsdom and the minium is now 18. Which could be the reason why the e2e tests for Node 16 are not passing.

[andreibereczki]

@jeremy-daley-kr : well the e2e tests running on ci will prevent this pr from being merged, so i would consider that blocking.

Just pointing out Node 16 support was dropped in jsdom and the minium is now 18. Which could be the reason why the e2e tests for Node 16 are not passing.
yes, maybe. taking this into consideration: #15461 do you think it would be considered to drop the node 16 e2e tests anytime soon?

[github-actions]

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[imnasnainaec]

@andreibereczki All the tests are passing on main again (since an April 18 commit), so you may want to update this branch.

[Julien-Marcou]

Also, I think you should update the canvas peer dependency to v3.0.0, as jsdom v26 is using canvas v3 now

  "peerDependencies": {
    "canvas": "^3.0.0",

This would get rid of the deprecation warnings regarding rimraf, npmlog, are-we-there-yet & gauge 😅

(While, upgrading to jsdom v26 allows to get rid of the deprecation warnings regarding abab & domexception)

[andreibereczki]

@andreibereczki All the tests are passing on main again (since an April 18 commit), so you may want to update this branch.

after sync with main i get different build errors. Are these on main as well? They don't seem related to my changes.

[Julien-Marcou]

It looks like the yarn install updated the parse5 package from v7.2.1 to v7.3.0, which in turn updated the entities package from v4 to v6, which has the same issue as you have: inikulin/parse5#1481

So it's probably an issue within the entities package itself

[andreibereczki]

do we wait for a fix or should we temporarily override the package version for parse5 for all dependants?

[Julien-Marcou]

I asked the maintainer of parse5 if they could fix the version of entities on their side, and they are looking into it, so we should be fine waiting for a fix

[jsangmeister]

also resolves #15507 :)

[cpojer]

What's the status of this PR?

[cpojer]

We dropped Node 16, so let's make this happen.

[cpojer]

Rebased, let's ship it.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.