[Feature]: Upgrade jest-environment-jsdom dependency to jsdom@^26.0.0

[ThomasGreenspan]

🚀 Feature Proposal

For package jest-environment-jsdom, change dependency on jsdom from:
"jsdom": "^22.0.0"
to
"jsdom": "^25.0.1"

Edit: now should be ^26.0.0

Motivation

jsdom versions before 25.0.1 (including 25.0.0) indirectly rely on punycode which is deprecated and emits deprecation warnings for every test.

A more detailed explanation can be found on this older issue which was closed without addressing (although I believe it needs to be ugpraded all the way up to v25):
#15148

Example

No response

Pitch

The package already relies on jsdom, this is just requesting an upgrade of one of its dependencies.

I currently use a dependency override and the behavior is fully preserved. Of course, I have a limited set of tests so I'm not sure that there is no impact but it is possible that this is a very small effortless change. While the override does handle my issue, overrides are always a little dangerous and I think it would be good for the lib to not rely on deprecated code.

[loucadufault]

Further motivation: a number of APIs are missing in older jsdom versions that were recently added, e.g. crypto.randomUUID() added in jsdom@22.1.0

[loucadufault]

As a side-note, the current latest jest-environemnt-jsdom@29.7.0 depends on jsdom@^20.0.0 (not 22.0.0 as mentioned in the original issue post).

[davidagitlen]

As a follow-on to the above side-note, including jsdom@^20.0.0 also has the side effect of pulling deprecated code like abab and outdated versions of data-urls ...

[dmurvihill]

+1. it looks like the latest alpha still has jsdom 22. But v23 is the first one without the deprecated abab and domexception packages.

% npm install -D jest jest-environment-jsdom @testing-library/react @testing-library/dom @testing-library/jest-dom
npm warn deprecated abab@2.0.6: Use your platform's native atob() and btoa() methods instead
npm warn deprecated domexception@4.0.0: Use your platform's native DOMException instead

% npm ls abab
todo-heap@0.1.0 /Users/dolan/IdeaProjects/todo-heap
└─┬ jest-environment-jsdom@29.7.0
  └─┬ jsdom@20.0.3
    ├── abab@2.0.6
    └─┬ data-urls@3.0.2
      └── abab@2.0.6 deduped

 % npm ls domexception
todo-heap@0.1.0 /Users/dolan/IdeaProjects/todo-heap
└─┬ jest-environment-jsdom@29.7.0
  └─┬ jsdom@20.0.3
    └── domexception@4.0.0

[lintu22]

Versions of jsdom below 24.1.2 rely on a vulnerable version of ws package. https://nvd.nist.gov/vuln/detail/CVE-2024-37890.

[jemunk]

How about giving this issue a bit more focus like changing it from a Feature Request to a Bug?

[tylerd-canva]

even renovate wants this #15276

[brinehart]

Any updates on this? We are still seeing this message on every one of our test suite runs:

(node:10249) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

It's rather annoying.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[davidagitlen]

I would still like this to be fixed, so... it's not stale to me

[it11ah1]

With jsdom@^26.0.0 "Error: Could not parse CSS stylesheet" when css @layer rule is used would also be fixed...

[andreibereczki]

+1. this would fix all the above mentioned issues and more. please upgrade this dependency