refactor(jest-runner): remove unnecessary ProcessTerminatedError logic #12287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12287 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 328 328
Lines 17246 17237 -9
Branches 5071 5065 -6
=======================================
- Hits 11643 11638 -5
+ Misses 5570 5566 -4
Partials 33 33
Continue to review full report at Codecov.
|
SimenB
reviewed
Feb 1, 2022
SimenB
approved these changes
Feb 1, 2022
|
I force-pushed just to restart CI. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Long story short, I was playing with a custom runner by adapting the code from Jest repo. As always I tried to understand how it works. All was more or less clear except the
if (err.type === 'ProcessTerminatedError')part. What is this error? Is it originating from the worker, or child process, or Node in general? Seems like not.Searching around points to
worker-farmlibrary which has ProcessTerminatedError. Theworker-farmwas introduced with #540 and remove in #4825.if (err.type === 'ProcessTerminatedError')got added withworker-farm, but was not removed later.Perhaps there is something I missed, but it seems like
if (err.type === 'ProcessTerminatedError')does nothing and can be safely removed. Or?Test plan
All test should pass.