Skip to content

Conversation

@mjesun
Copy link
Contributor

@mjesun mjesun commented Nov 2, 2017

This PR migrates jest-runner to use jest-worker, instead of worker-farm. As a consequence of this, some additional changes were done:

  • pify is not needed anymore as well.
  • Interfaces are now shared between parent and child processes, so we ensure they stay in sync.
  • Tests needed small adjustments as well.

@mjesun
Copy link
Contributor Author

mjesun commented Nov 2, 2017

This PR supersedes #4596, which was incorrect from a branch name, description and content point of view.

);
} catch (error) {
callback(formatError(error));
} catch (err) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you call it error again? It's an error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done; I didn't even notice; usually I use err by convention; like evt for events.

rawModuleMap: watcher.isWatchMode()
? test.context.moduleMap.getRawModuleMap()
: null,
: undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake I guess. I reverted that one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I found why. The expressed type was incorrect. I fixed it in a second commit.

@codecov-io
Copy link

Codecov Report

Merging #4825 into master will increase coverage by 0.24%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4825      +/-   ##
=========================================
+ Coverage   59.15%   59.4%   +0.24%     
=========================================
  Files         200     200              
  Lines        6660    6643      -17     
  Branches        4       3       -1     
=========================================
+ Hits         3940    3946       +6     
+ Misses       2720    2697      -23
Impacted Files Coverage Δ
packages/jest-runner/src/test_worker.js 0% <0%> (ø) ⬆️
packages/jest-runner/src/index.js 37.77% <25%> (-0.53%) ⬇️
packages/jest-haste-map/src/worker.js 93.93% <0%> (-1.9%) ⬇️
packages/jest-haste-map/src/index.js 96.8% <0%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b4b15...b5674ab. Read the comment docs.

@cpojer cpojer merged commit eb70265 into jestjs:master Nov 3, 2017
SimenB added a commit to SimenB/jest that referenced this pull request Nov 22, 2017
@mjesun mjesun deleted the migrate-jest-runner branch December 6, 2017 11:46
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants