-
-
Couldn't load subscription status.
- Fork 6.6k
Migrate jest-runner to jest-worker #4825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR supersedes #4596, which was incorrect from a branch name, description and content point of view. |
| ); | ||
| } catch (error) { | ||
| callback(formatError(error)); | ||
| } catch (err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you call it error again? It's an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done; I didn't even notice; usually I use err by convention; like evt for events.
packages/jest-runner/src/index.js
Outdated
| rawModuleMap: watcher.isWatchMode() | ||
| ? test.context.moduleMap.getRawModuleMap() | ||
| : null, | ||
| : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mistake I guess. I reverted that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I found why. The expressed type was incorrect. I fixed it in a second commit.
Codecov Report
@@ Coverage Diff @@
## master #4825 +/- ##
=========================================
+ Coverage 59.15% 59.4% +0.24%
=========================================
Files 200 200
Lines 6660 6643 -17
Branches 4 3 -1
=========================================
+ Hits 3940 3946 +6
+ Misses 2720 2697 -23
Continue to review full report at Codecov.
|
This reverts commit eb70265.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR migrates
jest-runnerto usejest-worker, instead ofworker-farm. As a consequence of this, some additional changes were done:pifyis not needed anymore as well.