Skip to content

Add column "Created" #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
strazto wants to merge 1 commit into from
Closed

Add column "Created" #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/src/javascript/components/torrent-list/SortDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const SORT_PROPERTIES = [
'upTotal',
'sizeBytes',
'dateAdded',
'dateFinished',
] as const;

interface SortDropdownProps {
Expand Down
3 changes: 3 additions & 0 deletions client/src/javascript/components/torrent-list/TorrentListCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const ICONS: Partial<Record<TorrentListColumn, JSX.Element>> = {
hash: <Hash />,
dateAdded: <Calendar />,
dateCreated: <CalendarCreated />,
dateFinished: <Calendar />,
Copy link
Owner

@jesec jesec May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need a new icon here.

isPrivate: <Lock />,
message: <TrackerMessage />,
percentComplete: <DownloadThick />,
Expand Down Expand Up @@ -116,6 +117,8 @@ const DefaultTorrentListCellContent: FC<TorrentListCellContentProps> = observer(
return <DateCell date={torrent[column]} />;
case 'dateCreated':
return <DateCell date={torrent[column]} />;
case 'dateFinished':
return <DateCell date={torrent[column]} />;
case 'downRate':
return <Size value={torrent[column]} isSpeed />;
case 'upRate':
Expand Down
1 change: 1 addition & 0 deletions client/src/javascript/constants/SortDirections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

const SortDirections: Record<string, 'asc' | 'desc'> = {
dateAdded: 'desc',
dateFinished: 'desc',
downRate: 'desc',
downTotal: 'desc',
upRate: 'desc',
Expand Down
1 change: 1 addition & 0 deletions client/src/javascript/constants/TorrentListColumns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const TorrentListColumns = {
dateAdded: 'torrents.properties.date.added',
dateFinished: 'torrents.properties.date.finished',
downRate: 'torrents.properties.download.speed',
downTotal: 'torrents.properties.download.total',
eta: 'torrents.properties.eta',
Expand Down
1 change: 1 addition & 0 deletions client/src/javascript/i18n/strings/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@
"torrents.properties.comment": "Comment",
"torrents.properties.date.added": "Added",
"torrents.properties.date.created": "Created",
"torrents.properties.date.finished": "Completed",
Copy link
Owner

@jesec jesec May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished would be more consistent here.

"torrents.properties.directory": "Location",
"torrents.properties.download.speed": "Download Speed",
"torrents.properties.download.total": "Downloaded",
Expand Down
2 changes: 2 additions & 0 deletions shared/constants/defaultFloodSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const defaultFloodSettings: Readonly<FloodSettings> = {
{id: 'seeds', visible: true},
{id: 'dateAdded', visible: true},
{id: 'dateCreated', visible: false},
{id: 'dateFinished', visible: true},
Copy link
Owner

@jesec jesec May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to display this by default?

Copy link
Author

@strazto strazto May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you

Copy link
Author

@strazto strazto May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you don't want it displayed by default, so I'll change it.

{id: 'directory', visible: false},
{id: 'hash', visible: false},
{id: 'isPrivate', visible: false},
Expand All @@ -41,6 +42,7 @@ const defaultFloodSettings: Readonly<FloodSettings> = {
seeds: 100,
dateAdded: 100,
dateCreated: 100,
dateFinished: 100,
directory: 100,
hash: 100,
isPrivate: 100,
Expand Down