Conversation
|
@jesec - Would you mind reviewing? |
I'm glad to hear that's the expectation, since that's all I did - do you think you could document this in the contributor guidelines? |
I don't understand how that relates to this PR. |
| hash: <Hash />, | ||
| dateAdded: <Calendar />, | ||
| dateCreated: <CalendarCreated />, | ||
| dateFinished: <Calendar />, |
| "torrents.properties.comment": "Comment", | ||
| "torrents.properties.date.added": "Added", | ||
| "torrents.properties.date.created": "Created", | ||
| "torrents.properties.date.finished": "Completed", |
There was a problem hiding this comment.
Finished would be more consistent here.
| {id: 'seeds', visible: true}, | ||
| {id: 'dateAdded', visible: true}, | ||
| {id: 'dateCreated', visible: false}, | ||
| {id: 'dateFinished', visible: true}, |
There was a problem hiding this comment.
Do we want to display this by default?
There was a problem hiding this comment.
I'm guessing you don't want it displayed by default, so I'll change it.
I found myself confused about what was expected of me for the translations, I found it on another PR, and I think it could be documented somewhere in some contributing guidelines |
|
I just realized that while the title said "Created", the code actually adds a "Finished" column. A "Finished" column was added by #565, and we already have a "Created" column (at least for Condensed view). |
2 participants
Description
Related Issue
Saw it discussed in #360
Screenshots
Types of changes