Fix 'jerry-test-suite/13/13-011.js' fail in compact profile #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arguments object is not supported in compact profile, so remove the test from 'compact-profile-list'. Do not create arguments object on function calls in compact profile. Remove unnecessary arguments check. Related issue: jerryscript-project#879 JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
added
bug
|
LGTM |
|
LGTM too (FWIW) |
LaszloLango
added a commit
to LaszloLango/jerryscript
that referenced
this pull request
May 17, 2016
'test-js-precommit' target was unnecessary, because all of the jerry tests pass in compact profile as well. Related issue: jerryscript-project#879 Related PR: jerryscript-project#912 JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
added a commit
to LaszloLango/jerryscript
that referenced
this pull request
May 17, 2016
'test-js-precommit' target was unnecessary, because all of the jerry tests pass in compact profile as well. Related issue: jerryscript-project#879 Related PR: jerryscript-project#912 JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
added a commit
to LaszloLango/jerryscript
that referenced
this pull request
May 17, 2016
When performing `make precommit`, instead of running only a subset of the Jerry Test Suite on full profile builds, run the whole suite, and also run the compact subset of the suite on compact builds. Also, make CI perform the same tests. Related issue: jerryscript-project#879 Related PR: jerryscript-project#912 JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
added a commit
to LaszloLango/jerryscript
that referenced
this pull request
May 17, 2016
When performing `make precommit`, instead of running only a subset of the Jerry Test Suite on full profile builds, run the whole suite, and also run the compact subset of the suite on compact builds. Also, make CI perform the same tests. Related issue: jerryscript-project#879 Related PR: jerryscript-project#912 JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguments object is not supported in compact profile, so remove
the test from 'compact-profile-list'. Do not create arguments
object on function calls in compact profile. Remove unnecessary
arguments check.
Related issue: #879
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com