Remove 'test-js-precommit' target from Makefile #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
enhancement
|
LGTM |
LaszloLango
force-pushed
the
remove-test-js-precommit
branch
from
c20e4ac to
618b7c4
Compare
|
This patch seems to make the whole "precommit" subset of the Jerry Test Suite superfluous. Then, there are more "leftovers" to remove:
|
LaszloLango
force-pushed
the
remove-test-js-precommit
branch
from
618b7c4 to
c614175
Compare
LaszloLango
changed the title
|
@akiss77, thanks for pointing out. I've updated the PR. |
When performing `make precommit`, instead of running only a subset of the Jerry Test Suite on full profile builds, run the whole suite, and also run the compact subset of the suite on compact builds. Also, make CI perform the same tests. Related issue: jerryscript-project#879 Related PR: jerryscript-project#912 JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
|
LGTM |
LaszloLango
force-pushed
the
remove-test-js-precommit
branch
from
c614175 to
1938415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing
make precommit, instead of running only a subset ofthe Jerry Test Suite on full profile builds, run the whole suite, and
also run the compact subset of the suite on compact builds. Also, make
CI perform the same tests.
Related issue: #879
Related PR: #912
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com