Skip to content

Fix processing of elision in array literal #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2015

Conversation

sand1k
Copy link
Contributor

@sand1k sand1k commented Aug 24, 2015

Fixes the following tests from test262:

  • ch15/15.2/15.2.3/15.2.3.6/15.2.3.6-4-159.js
  • ch15/15.2/15.2.3/15.2.3.6/15.2.3.6-4-160.js
  • ch15/15.2/15.2.3/15.2.3.7/15.2.3.7-6-a-155.js
  • ch15/15.2/15.2.3/15.2.3.7/15.2.3.7-6-a-156.js
  • ch15/15.4/15.4.4/15.4.4.14/15.4.4.14-9-a-10.js
  • ch15/15.4/15.4.4/15.4.4.14/15.4.4.14-9-b-1.js
  • ch15/15.4/15.4.4/15.4.4.14/15.4.4.14-9-b-i-15.js
  • ch15/15.4/15.4.4/15.4.4.14/15.4.4.14-9-b-i-7.js
  • ch15/15.4/15.4.4/15.4.4.15/15.4.4.15-8-a-10.js
  • ch15/15.4/15.4.4/15.4.4.15/15.4.4.15-8-b-1.js
  • ch15/15.4/15.4.4/15.4.4.15/15.4.4.15-8-b-i-15.js
  • ch15/15.4/15.4.4/15.4.4.15/15.4.4.15-8-b-i-7.js
  • ch15/15.4/15.4.4/15.4.4.16/15.4.4.16-7-b-11.js
  • ch15/15.4/15.4.4/15.4.4.16/15.4.4.16-7-b-7.js
  • ch15/15.4/15.4.4/15.4.4.16/15.4.4.16-7-c-i-16.js
  • ch15/15.4/15.4.4/15.4.4.16/15.4.4.16-7-c-i-8.js
  • ch15/15.4/15.4.4/15.4.4.17/15.4.4.17-7-b-11.js
  • ch15/15.4/15.4.4/15.4.4.17/15.4.4.17-7-b-7.js
  • ch15/15.4/15.4.4/15.4.4.17/15.4.4.17-7-c-i-16.js
  • ch15/15.4/15.4.4/15.4.4.17/15.4.4.17-7-c-i-8.js
  • ch15/15.4/15.4.4/15.4.4.18/15.4.4.18-7-b-11.js
  • ch15/15.4/15.4.4/15.4.4.18/15.4.4.18-7-b-7.js
  • ch15/15.4/15.4.4/15.4.4.18/15.4.4.18-7-c-i-16.js
  • ch15/15.4/15.4.4/15.4.4.18/15.4.4.18-7-c-i-8.js
  • ch15/15.4/15.4.4/15.4.4.19/15.4.4.19-8-b-11.js
  • ch15/15.4/15.4.4/15.4.4.19/15.4.4.19-8-b-7.js
  • ch15/15.4/15.4.4/15.4.4.19/15.4.4.19-8-c-i-16.js
  • ch15/15.4/15.4.4/15.4.4.19/15.4.4.19-8-c-i-8.js
  • ch15/15.4/15.4.4/15.4.4.20/15.4.4.20-9-b-11.js
  • ch15/15.4/15.4.4/15.4.4.20/15.4.4.20-9-b-7.js
  • ch15/15.4/15.4.4/15.4.4.20/15.4.4.20-9-c-i-16.js
  • ch15/15.4/15.4.4/15.4.4.20/15.4.4.20-9-c-i-8.js
  • ch15/15.4/15.4.4/15.4.4.21/15.4.4.21-8-b-iii-1-16.js
  • ch15/15.4/15.4.4/15.4.4.21/15.4.4.21-8-b-iii-1-8.js
  • ch15/15.4/15.4.4/15.4.4.21/15.4.4.21-9-b-11.js
  • ch15/15.4/15.4.4/15.4.4.21/15.4.4.21-9-b-20.js
  • ch15/15.4/15.4.4/15.4.4.21/15.4.4.21-9-b-24.js
  • ch15/15.4/15.4.4/15.4.4.21/15.4.4.21-9-b-7.js
  • ch15/15.4/15.4.4/15.4.4.21/15.4.4.21-9-c-i-16.js
  • ch15/15.4/15.4.4/15.4.4.21/15.4.4.21-9-c-i-8.js
  • ch15/15.4/15.4.4/15.4.4.22/15.4.4.22-8-b-iii-1-16.js
  • ch15/15.4/15.4.4/15.4.4.22/15.4.4.22-8-b-iii-1-8.js
  • ch15/15.4/15.4.4/15.4.4.22/15.4.4.22-9-b-11.js
  • ch15/15.4/15.4.4/15.4.4.22/15.4.4.22-9-b-20.js
  • ch15/15.4/15.4.4/15.4.4.22/15.4.4.22-9-b-24.js
  • ch15/15.4/15.4.4/15.4.4.22/15.4.4.22-9-b-7.js
  • ch15/15.4/15.4.4/15.4.4.22/15.4.4.22-9-c-i-16.js
  • ch15/15.4/15.4.4/15.4.4.22/15.4.4.22-9-c-i-8.js

@egavrin egavrin added bug Undesired behaviour parser Related to the JavaScript parser labels Aug 24, 2015
@egavrin
Copy link
Contributor

egavrin commented Aug 24, 2015

Good to me

@zherczeg
Copy link
Member

LGTM

JerryScript-DCO-1.0-Signed-off-by: Andrey Shitov a.shitov@samsung.com
@sand1k sand1k force-pushed the fix-processing-of-elision-in-array-literal branch from b1c2af0 to e4843ec Compare August 24, 2015 11:51
@sand1k sand1k merged commit e4843ec into master Aug 24, 2015
@sand1k sand1k deleted the fix-processing-of-elision-in-array-literal branch August 24, 2015 12:25
@galpeter
Copy link
Contributor

FYI: last time I did this fix (#319) I was told that adding a new simple value is not a good way to resolve the issue. Issue report: #356

@sand1k
Copy link
Contributor Author

sand1k commented Aug 24, 2015

@galpeter, thank you for pointing this. We'll discuss it and, probably, make an update then.

@ruben-ayrapetyan
Copy link
Contributor

I think new simple value is not necessary in the case.

@ruben-ayrapetyan
Copy link
Contributor

The only thing that seems to be necessary is support of empty varg, and update of array_decl opcode handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour parser Related to the JavaScript parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants