-
Notifications
You must be signed in to change notification settings - Fork 683
Empty values in array creation should be not set #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty values in array creation should be not set #319
Conversation
When creating arrays it is possible to set 'empty' values which are not undefined, but simply unused values. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
One related test262 testcase: https://github.com/tc39/test262/blob/es5-tests/test/suite/ch15/15.2/15.2.3/15.2.3.7/15.2.3.7-6-a-155.js |
+1 lgtm |
I think, this should be fixed by modification of byte-code / opcode handlers, without introduction of a new simple value. |
Is there any issue opened for this? |
@ruben-ayrapetyan , there is no issue opened for this. I'll create one. I've got one question regarding the byte-code/opcode way: in the |
Created issue: #356 |
@galpeter, thank you! ECMA-262 v5, 11.1.4 defines that array object should be created empty, and then filled, step by step. So, we don't need to pass 'unset' arguments to |
So that means that we the |
@galpeter @ruben-ayrapetyan let's close this PR is everyone is OK to continue with #356. |
Ok. |
When creating arrays it is possible to set 'empty' values
which are not undefined, but simply unused values.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com