Skip to content

Remove @Nullable annotation #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Remove @Nullable annotation #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jenkinsci/plugins/workflow/steps/StepContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public abstract class StepContext implements FutureCallback<Object>, Serializabl
* @see BodyInvoker#withContext
* @see DynamicContext
*/
public abstract @Nullable <T> T get(Class<T> key) throws IOException, InterruptedException;
public abstract <T> T get(Class<T> key) throws IOException, InterruptedException;

@Override public abstract void onSuccess(@Nullable Object result);
Copy link
Member

@jglick jglick Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this one?

Copy link
Member Author

@basil basil Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one has not caused me any issues so far in the handful of tests I ran with the new version of SpotBugs.

Copy link
Member

@jglick jglick Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let us leave it for now, but it seems that SpotBugs devs have picked an interpretation of @Nullable which basically makes it a confusing synonym for @CheckForNull which should probably just be avoided generally.


Expand Down