Remove @Nullable annotation
#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2024
Closed
Member
Hmm, that is supposed to be what |
jglick
approved these changes
Jul 5, 2024
| public abstract @Nullable <T> T get(Class<T> key) throws IOException, InterruptedException; | ||
| public abstract <T> T get(Class<T> key) throws IOException, InterruptedException; | ||
|
|
||
| @Override public abstract void onSuccess(@Nullable Object result); |
Member
Author
There was a problem hiding this comment.
This one has not caused me any issues so far in the handful of tests I ran with the new version of SpotBugs.
Member
There was a problem hiding this comment.
OK, let us leave it for now, but it seems that SpotBugs devs have picked an interpretation of @Nullable which basically makes it a confusing synonym for @CheckForNull which should probably just be avoided generally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of
spotbugs-maven-pluginno longer ignoreNullableand treat the presence of this annotation as a reason to log a new warning whenever anyone calls this method and doesn't check the result for null. Since our plugins do this in dozens of places this creates a lot of new warnings. This PR restores the old behavior by removing theNullableannotation.Testing done
mvn clean verify -DskipTestsworkflow-durable-task-stepplugin with SpotBugs 4.8.6.0; verified that after this PR most of the new warnings went away.