Skip to content

Misc cleanup of pom.xml #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Misc cleanup of pom.xml #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c79004c
Misc cleanup of pom.xml
jakub-bochenski Jan 29, 2019
1e1fabb
Update pom.xml
jakub-bochenski Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@
<artifactId>stash-pullrequest-builder</artifactId>
<version>${revision}${changelist}</version>
<packaging>hpi</packaging>

<name>Stash Pullrequest Builder Plugin</name>
<description>This Jenkins plugin builds pull requests from Stash and will report the test results.</description>
<url>https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin</url>
<description>This plugin builds Stash pull requests and posts the build results on Stash</description>
<url>https://wiki.jenkins.io/display/JENKINS/Stash+pullrequest+builder+plugin</url>

<developers>
<developer>
Expand All @@ -39,11 +40,23 @@
<url>https://github.com/jenkinsci/stash-pullrequest-builder-plugin</url>
</scm>

<distributionManagement>
<repository>
<id>maven.jenkins-ci.org</id>
<name>jenkinsci-releases</name>
<url>https://repo.jenkins-ci.org/releases</url>
</repository>
<snapshotRepository>
<id>maven.jenkins-ci.org</id>
<name>jenkinsci-snapshots</name>
<url>https://repo.jenkins-ci.org/snapshots</url>
</snapshotRepository>
</distributionManagement>

<properties>
<revision>1.7.1</revision>
<changelist>-SNAPSHOT</changelist>
<java.level>8</java.level>
<!--<jenkins.version>2.7.4</jenkins.version>-->
</properties>

<dependencies>
Expand Down Expand Up @@ -73,19 +86,17 @@
<version>2.1.5</version>
</dependency>
</dependencies>

<!-- get every artifact through repo.jenkins-ci.org, which proxies all the artifacts that we need -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a big reason to remove this comment? Or was it cut as "a" comment along with other cleanup?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because it's a "what" comment and not a "why" comment.
Also it's kind of obvious while on the other hand not being technically correct (it's not a proxy)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. Guess a "mirror" would be more correct :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, FYI: another thing is it's just adding a new repository to the list, it doesn't "disable" maven central etc.


<repositories>
<repository>
<id>repo.jenkins-ci.org</id>
<url>http://repo.jenkins-ci.org/public/</url>
<url>https://repo.jenkins-ci.org/public/</url>
</repository>
</repositories>

<pluginRepositories>
<pluginRepository>
<id>repo.jenkins-ci.org</id>
<url>http://repo.jenkins-ci.org/public/</url>
<url>https://repo.jenkins-ci.org/public/</url>
</pluginRepository>
</pluginRepositories>

Expand Down