Misc cleanup of pom.xml #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WTF is happening to the Jenkis Azure cluster today? |
|
retest this please |
jakub-bochenski
force-pushed
the
jakub-bochenski-patch-5
branch
from
6fa7d56 to
c79004c
Compare
proski
approved these changes
Jan 31, 2019
jimklimov
approved these changes
Feb 14, 2019
| @@ -73,19 +86,17 @@ | |||
| <version>2.1.5</version> | |||
| </dependency> | |||
| </dependencies> | |||
|
|
|||
| <!-- get every artifact through repo.jenkins-ci.org, which proxies all the artifacts that we need --> | |||
There was a problem hiding this comment.
Is there a big reason to remove this comment? Or was it cut as "a" comment along with other cleanup?
There was a problem hiding this comment.
It's because it's a "what" comment and not a "why" comment.
Also it's kind of obvious while on the other hand not being technically correct (it's not a proxy)
There was a problem hiding this comment.
Ok, thanks. Guess a "mirror" would be more correct :)
There was a problem hiding this comment.
Yes, FYI: another thing is it's just adding a new repository to the list, it doesn't "disable" maven central etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.