Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @Override annotations #5430

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Conversation

basil
Copy link
Member

@basil basil commented Apr 17, 2021

Amends #5323 by adding more missing @Override annotations. I generated #5323 with IntelliJ IDEA, but since then I discovered that Eclipse and Error Prone (both of which I used to generate this PR) do a better job.

@basil basil added the skip-changelog Should not be shown in the changelog label Apr 17, 2021
@oleg-nenashev
Copy link
Member

oleg-nenashev commented Apr 18, 2021 via email

@basil basil added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Apr 19, 2021
@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 19, 2021
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@res0nance res0nance merged commit f637867 into jenkinsci:master Apr 28, 2021
@basil basil deleted the override branch April 28, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants