Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @Override annotations #5323

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

basil
Copy link
Member

@basil basil commented Mar 2, 2021

Using the@Override annotation consistently is desirable for two reasons:

  • It produces a compiler warning if the annotated method doesn't actually override anything (e.g., if there is a misspelling).
  • It improves readability by making it explicitly clear that methods are overridden.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will likely need codestyle checker if we want to enforce it in the future.

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog labels Mar 3, 2021
@oleg-nenashev oleg-nenashev merged commit 62fdb42 into jenkinsci:master Mar 4, 2021
@basil basil deleted the override branch March 6, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants