Skip to content

[GitLab Pipeline Status]: do not set final build status while build is still ongoing #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jetersen merged 1 commit into from
Sep 19, 2023
Merged

[GitLab Pipeline Status]: do not set final build status while build is still ongoing #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ...main/java/io/jenkins/plugins/gitlabbranchsource/helpers/GitLabPipelineStatusNotifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ static Long getSourceProjectId(Job job, GitLabApi gitLabApi, String projectPath)
/**
* Sends notifications to GitLab on Checkout (for the "In Progress" Status).
*/
private static void sendNotifications(Run<?, ?> build, TaskListener listener) {
private static void sendNotifications(Run<?, ?> build, TaskListener listener, Boolean useResult) {
GitLabSCMSource source = getSource(build);
if (source == null) {
return;
Expand All @@ -298,8 +298,11 @@ private static void sendNotifications(Run<?, ?> build, TaskListener listener) {
+ " configured in Jenkins global configuration.");
return;
}
Result result = build.getResult();
LOGGER.log(Level.FINE, String.format("Result: %s", result));
Result result = null;
if (useResult) {
result = build.getResult();
LOGGER.log(Level.FINE, String.format("Result: %s", result));
}

CommitStatus status = new CommitStatus();
Constants.CommitBuildState state;
Expand Down Expand Up @@ -521,7 +524,7 @@ public void onCheckout(
File changelogFile,
SCMRevisionState pollingBaseline) {
LOGGER.log(Level.FINE, String.format("SCMListener: Checkout > %s", build.getFullDisplayName()));
sendNotifications(build, listener);
sendNotifications(build, listener, false);
}
}

Expand All @@ -534,14 +537,14 @@ public static class JobCompletedListener extends RunListener<Run<?, ?>> {
@Override
public void onCompleted(Run<?, ?> build, @NonNull TaskListener listener) {
LOGGER.log(Level.FINE, String.format("RunListener: Complete > %s", build.getFullDisplayName()));
sendNotifications(build, listener);
sendNotifications(build, listener, true);
logComment(build, listener);
}

@Override
public void onStarted(Run<?, ?> run, TaskListener listener) {
LOGGER.log(Level.FINE, String.format("RunListener: Started > %s", run.getFullDisplayName()));
sendNotifications(run, listener);
sendNotifications(run, listener, false);
}
}
}