Skip to content

Conversation

@lmife
Copy link
Contributor

@lmife lmife commented Feb 22, 2023

Only notify status RUNNING during onStarted() and onCheckout(). Update status based on build result only in onComplete().

https://issues.jenkins.io/browse/JENKINS-70661

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Please tell me if the code change does not meet your coding guidelines etc. I'm not a Java developer but I will do my best to meet your requirements.

@lmife lmife requested a review from jetersen as a code owner February 22, 2023 13:47
@lmife lmife force-pushed the JENKINS-70661-gitlab-pipeline-status-wrong-result-notification branch from d6bad3c to e802ba4 Compare May 26, 2023 20:35
Only notify status RUNNING during onStarted() and onCheckout().
@lmife lmife force-pushed the JENKINS-70661-gitlab-pipeline-status-wrong-result-notification branch from e802ba4 to 6e82d23 Compare June 30, 2023 09:29
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jetersen jetersen added the bug Something isn't working label Sep 19, 2023
@jetersen jetersen merged commit 0b63b03 into jenkinsci:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants