FIX Jenkins 39809 404 pages appear only in pipeline page children #622

scherler · 2016-11-23T17:23:51Z

Description

I left a FIXME note for @imeredith since I am not yet familiar with the mobx stuff and we need to return some object that indicates that we have to show the 404.

AT PR: jenkinsci/blueocean-acceptance-test#71
Passing ATH: https://ci.blueocean.io/blue/organizations/jenkins/ATH-Jenkinsfile/detail/JENKINS-39809_404_pages_appear_only_in_pipelinePage_children/4

Submitter checklist

Link to JIRA ticket in description, if appropriate.
Change is code complete and matches issue description
Appropriate unit or acceptance tests or explanation to why this change has no tests
Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
Ran Acceptance Test Harness against PR changes.

Reviewer checklist

Run the changes and verified the change matches the issue description
Reviewed the code
Verified that the appropriate tests have been written or valid explanation given

@jenkinsci/code-reviewers @reviewbybees

…move not found to core

…w location

…ages_appear_only_in_pipelinePage_children

…09_404_pages_appear_only_in_pipelinePage_children

…] Use #616 to fix extension bug. thx tfennellyg ds

…] Fix deps for the builder and remove dups in package.son

…] fix imports

…] add FIXME note and raise version

…] Use notFound component

…] use new plugin version

…ages_appear_only_in_pipelinePage_children

ghost · 2016-11-24T12:29:51Z

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

… unused imports

… shrinkCrap so much. I have lost so many hours on that crap tool. Unbelievable

michaelneale · 2016-11-25T00:04:38Z

Some things I tried:

Activity screen with non existing pipeline name: works
Dashboard with nonsense path: works
Result screen with non existent pipeline name or run: doesn't work, although API shows up 404 - and 🐜 unless you mean this is what you need Ivan to look at?

So if the scope of this is narrowed to be those - then 🐝 from be (and thanks for ATH too!)

Can you make a follow on ticket for Ivan or something to deal with the results screen not showing 404 @scherler ?

michaelneale · 2016-11-25T00:05:10Z

blueocean-core-js/src/js/services/ActivityService.js

@@ -90,6 +90,9 @@ export class ActivityService extends BunkerService {
                    run.result = 'UNKNOWN';
                }
                return this.setItem(run);
+            })
+            .catch(err => {
+                console.log('There had been an error while trying to get the data.', err); // FIXME: Ivan what is the way to return an "error" opbject so underlying component are aware of the problem and can react


"There has" - as past tense doesn't make sense here 🐜

and this is where it knows it is a 404, eg on results screen:

blueocean.js:1688 GET http://localhost:8080/jenkins/blue/rest/organizations/jenkins/pipelines/keitha/branches/fdsfd/runs/3/ 404 (Not Found)request @ blueocean.js:1688dedupe @ blueocean.js:4475dedupe @ blueocean.js:4498rawFetchJSON @ blueocean.js:1699fetchJSON @ blueocean.js:1765fetchActivity @ blueocean.js:2694_fetchRun @ jenkins-js-extension.js:33974componentWillMount @ jenkins-js-extension.js:33948target.(anonymous function) @ jenkins-js-extension.js:9126performInitialMount @ blueocean.js:79317mountComponent @ blueocean.js:79224mountComponent @ blueocean.js:86237updateChildren @ blueocean.js:77502_reconcilerUpdateChildren @ blueocean.js:85090_updateChildren @ blueocean.js:85189updateChildren @ blueocean.js:85176_updateDOMChildren @ blueocean.js:80934updateComponent @ blueocean.js:80752receiveComponent @ blueocean.js:80710receiveComponent @ blueocean.js:86316_updateRenderedComponent @ blueocean.js:79718_performComponentUpdate @ blueocean.js:79688updateComponent @ blueocean.js:79609receiveComponent @ blueocean.js:79511receiveComponent @ blueocean.js:86316_updateRenderedComponent @ blueocean.js:79718_performComponentUpdate @ blueocean.js:79688updateComponent @ blueocean.js:79609performUpdateIfNecessary @ blueocean.js:79525performUpdateIfNecessary @ blueocean.js:86348runBatchedUpdates @ blueocean.js:87387perform @ blueocean.js:89435perform @ blueocean.js:89435perform @ blueocean.js:87326flushBatchedUpdates @ blueocean.js:87409closeAll @ blueocean.js:89501perform @ blueocean.js:89448batchedUpdates @ blueocean.js:83118enqueueUpdate @ blueocean.js:87437enqueueUpdate @ blueocean.js:87045enqueueForceUpdate @ blueocean.js:87178ReactComponent.forceUpdate @ blueocean.js:78557(anonymous function) @ jenkins-js-extension.js:9158Reaction.runReaction @ jenkins-js-extension.js:11108runReactions @ blueocean.js:59540transactionEnd @ blueocean.js:59612executeAction @ blueocean.js:58863res @ blueocean.js:58831(anonymous function) @ blueocean.js:3874 blueocean.js:2706 There had been an error while trying to get the data. Error: Not Found(…)

I talked to @imeredith and he wanted to extend the pager to return an object such as:

{ data, error, state }

That will hopefully go away anyway but will fix the working.

michaelneale · 2016-11-25T00:13:06Z

blueocean-dashboard/package.json

@@ -15,7 +15,7 @@
  },
  "devDependencies": {
    "@jenkins-cd/eslint-config-jenkins": "0.0.2",
-    "@jenkins-cd/js-builder": "0.0.47",
+    "@jenkins-cd/js-builder": "0.0.49-beta6",


I wonder what goodness this brings

That is fixing a bug that we discovered when I moved the NotFound to core and had to introduce react-router as dep. Without that version that leads to an exception for the bundle. Kudos to @tfennelly

scherler · 2016-11-25T09:38:13Z

@michaelneale if you want we keep this PR open.

however I personally try to get PRs quickly in (still remembering the endless i18n branch which costs extra time to keep it in sync with master.

scherler · 2016-11-25T10:13:15Z

https://issues.jenkins-ci.org/browse/JENKINS-40032 is the followup for @imeredith

scherler added 11 commits November 20, 2016 23:59

[JENKINS-39809_404_pages_appear_only_in_pipelinePage_children] start …

e52d9f5

…move not found to core

[JENKINS-39809_404_pages_appear_only_in_pipelinePage_children] use ne…

f58f4ce

…w location

Merge remote-tracking branch 'origin/master' into JENKINS-39809_404_p…

70942ac

…ages_appear_only_in_pipelinePage_children

Merge remote-tracking branch 'origin/master' into trashed_JENKINS-398…

c1cf0e0

…09_404_pages_appear_only_in_pipelinePage_children

Merge remote-tracking branch 'origin/master' into trashed_JENKINS-398…

b36501c

…09_404_pages_appear_only_in_pipelinePage_children

[trashed_JENKINS-39809_404_pages_appear_only_in_pipelinePage_children…

eb384c9

…] Use #616 to fix extension bug. thx tfennellyg ds

[trashed_JENKINS-39809_404_pages_appear_only_in_pipelinePage_children…

9a30e27

…] Fix deps for the builder and remove dups in package.son

[trashed_JENKINS-39809_404_pages_appear_only_in_pipelinePage_children…

0d1d595

…] fix imports

[trashed_JENKINS-39809_404_pages_appear_only_in_pipelinePage_children…

9c212ef

…] add FIXME note and raise version

[trashed_JENKINS-39809_404_pages_appear_only_in_pipelinePage_children…

9508bc1

…] Use notFound component

[trashed_JENKINS-39809_404_pages_appear_only_in_pipelinePage_children…

742574c

…] use new plugin version

scherler added needs-review work-in-progress labels Nov 23, 2016

scherler added 2 commits November 23, 2016 18:38

eslint - formating changes and fix offences

c9defed

Merge remote-tracking branch 'origin/master' into JENKINS-39809_404_p…

dc85b69

…ages_appear_only_in_pipelinePage_children

scherler removed the work-in-progress label Nov 24, 2016

scherler changed the title ~~Jenkins 39809 404 pages appear only in pipeline page children~~ FIX Jenkins 39809 404 pages appear only in pipeline page children Nov 24, 2016

scherler added 2 commits November 24, 2016 15:46

[JENKINS-39809_404_pages_appear_only_in_pipelinePage_children] remove…

cc229c0

… unused imports

[JENKINS-39809_404_pages_appear_only_in_pipelinePage_children] I hate…

77b37b0

… shrinkCrap so much. I have lost so many hours on that crap tool. Unbelievable

michaelneale reviewed Nov 25, 2016

View reviewed changes

Fix grammar

044e4fd

scherler merged commit b9ee860 into master Nov 25, 2016

scherler deleted the JENKINS-39809_404_pages_appear_only_in_pipelinePage_children branch November 25, 2016 10:49

snyk-bot mentioned this pull request Dec 23, 2022

[Snyk] Security upgrade jsonwebtoken from 7.1.9 to 9.0.0 rkamisetti792/blueocean-plugin#73

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX Jenkins 39809 404 pages appear only in pipeline page children #622

FIX Jenkins 39809 404 pages appear only in pipeline page children #622

scherler commented Nov 23, 2016 •

edited by michaelneale

Loading

ghost commented Nov 24, 2016

michaelneale commented Nov 25, 2016 •

edited

Loading

michaelneale Nov 25, 2016

michaelneale Nov 25, 2016

scherler Nov 25, 2016

michaelneale Nov 25, 2016

scherler Nov 25, 2016

scherler commented Nov 25, 2016

scherler commented Nov 25, 2016

FIX Jenkins 39809 404 pages appear only in pipeline page children #622

FIX Jenkins 39809 404 pages appear only in pipeline page children #622

Conversation

scherler commented Nov 23, 2016 • edited by michaelneale Loading

Description

Submitter checklist

Reviewer checklist

ghost commented Nov 24, 2016

michaelneale commented Nov 25, 2016 • edited Loading

michaelneale Nov 25, 2016

Choose a reason for hiding this comment

michaelneale Nov 25, 2016

Choose a reason for hiding this comment

scherler Nov 25, 2016

Choose a reason for hiding this comment

michaelneale Nov 25, 2016

Choose a reason for hiding this comment

scherler Nov 25, 2016

Choose a reason for hiding this comment

scherler commented Nov 25, 2016

scherler commented Nov 25, 2016

scherler commented Nov 23, 2016 •

edited by michaelneale

Loading

michaelneale commented Nov 25, 2016 •

edited

Loading