Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

[FIX JENKINS-39809_404_pages_appear_only_in_pipelinePage_children] #71

Merged

Conversation

scherler
Copy link
Collaborator

Description

See JENKINS-39809.

Testing 404 pages.

@jenkinsci/code-reviewers @reviewbybees

Add notFound page. Better description of test case. Add 404 tests for different urls.

…tFound page. Better description of test case. Add 404 tests for differrent urls.
@ghost
Copy link

ghost commented Nov 24, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@scherler scherler changed the title [JENKINS-39809_404_pages_appear_only_in_pipelinePage_children] [FIX JENKINS-39809_404_pages_appear_only_in_pipelinePage_children] Nov 24, 2016
@michaelneale
Copy link
Member

🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝
🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝🐝 🐝🐝🐝🐝🐝🐝🐝🐝🐝

Love your work!

@scherler
Copy link
Collaborator Author

:) @michaelneale thank you very much. That feeling is mutual! Great work digging in and write ATH tests, good on ya mate!

@scherler scherler merged commit 66c7ed6 into master Nov 25, 2016
@scherler scherler deleted the JENKINS-39809_404_pages_appear_only_in_pipelinePage_children branch November 25, 2016 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants