Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing relativePath to parent #129

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Add missing relativePath to parent #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.86</version>
<relativePath />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonesbusy BTW the extra space is only necessary for plugins still using maven-release-plugin, since it has a buggy XML round-trip parser/generator that would forcibly reinsert it on every release. For plugins using CD,

Suggested change
<relativePath />
<relativePath/>

suffices. (XML never needed a space here; sometimes XHTML documents used it, to work around very old buggy web browsers which did not actually include XML parsers and tried to parse as HTML.)

</parent>
<artifactId>antisamy-markup-formatter</artifactId>
<version>${changelist}</version>
Expand Down
Loading