Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing relativePath to parent #129

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

jonesbusy
Copy link
Contributor

Ensure it get resolved from remote repository

Testing done

CI only

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure it get resolved from remote repository
@jonesbusy jonesbusy requested a review from a team as a code owner December 29, 2024 05:22
@@ -4,6 +4,7 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.86</version>
<relativePath />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonesbusy BTW the extra space is only necessary for plugins still using maven-release-plugin, since it has a buggy XML round-trip parser/generator that would forcibly reinsert it on every release. For plugins using CD,

Suggested change
<relativePath />
<relativePath/>

suffices. (XML never needed a space here; sometimes XHTML documents used it, to work around very old buggy web browsers which did not actually include XML parsers and tried to parse as HTML.)

@jglick jglick added the chore label Jan 2, 2025
@jglick jglick merged commit 1a99a24 into jenkinsci:master Jan 2, 2025
17 checks passed
@jonesbusy jonesbusy deleted the patch-1 branch January 2, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants