Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pr): Fix clean phase before committing changes #597

Merged
merged 13 commits into from
Jan 8, 2025
Merged

fix(pr): Fix clean phase before committing changes #597

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
44b4dff
Implement a way to customize the pull request body
gounthar Jan 8, 2025
9aadec0
Update pr-body-SetupJenkinsfile.jte
gounthar Jan 8, 2025
44b881c
fix(jte): Adding aria-label for better accessibility.
gounthar Jan 8, 2025
f335e37
fix(jte): Extracting common template name generation logic.
gounthar Jan 8, 2025
230c392
fix(jte): Extracting common template name generation logic.
gounthar Jan 8, 2025
bd7ccc6
fix(jte): Spotless.
gounthar Jan 8, 2025
6eb05d3
fix(jte): Adds a custom title for the SetupJenkinsfile recipe.
gounthar Jan 8, 2025
a6acc17
fix(jte): Reverts the custom title "optimization"
gounthar Jan 8, 2025
95c6d43
fix(jte): Reverts the custom title "optimization"
gounthar Jan 8, 2025
1b41c1b
fix(jte): Fix the double "jte" suffix.
gounthar Jan 8, 2025
9339c50
Merge pull request #76 from gounthar/customize-pr-body
gounthar Jan 8, 2025
c7c6abb
Merge branch 'jenkins-infra:main' into main
gounthar Jan 8, 2025
e6222a8
Fix clean phase before committing changes
gounthar Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(jte): Reverts the custom title "optimization"
  • Loading branch information
@gounthar
gounthar committed Jan 8, 2025
commit a6acc17af1f018eceebd459c18a6cb81490f3a59
5 changes: 2 additions & 3 deletions ...rnizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/utils/TemplateUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,8 @@ public static String renderCommitMessage(Plugin plugin, Recipe recipe) {
*/
public static String renderPullRequestTitle(Plugin plugin, Recipe recipe) {
if (hasTitleTemplate(recipe)) {
return renderTemplate(
"pr-title-%s.jte".formatted(getTemplateNameForRecipe("pr-title", recipe)),
Map.of("plugin", plugin, "recipe", recipe));
String shortName = recipe.getName().replaceAll(Settings.RECIPE_FQDN_PREFIX + ".", "");
return renderTemplate("pr-title-%s.jte".formatted(getTemplateNameForRecipe("pr-title", recipe)), Map.of("plugin", plugin, "recipe", recipe));
}
return renderTemplate("pr-title.jte", Map.of("plugin", plugin, "recipe", recipe));
}
Expand Down