fix(pr): Fix clean phase before committing changes #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #75 Add support for customizing the pull request body using `jte` template files. * Add a new method `hasBodyTemplate` in `TemplateUtils.java` to check for specific `jte` templates for the pull request body. * Update the `renderPullRequestBody` method in `TemplateUtils.java` to use specific `jte` templates if available. * Create a new `jte` template `pr-body-SetupJenkinsfile.jte` for customizing the pull request body for the `SetupJenkinsfile` recipe, including a detailed explanation of why this recipe is important. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/plugin-modernizer-tool/issues/75?shareId=XXXX-XXXX-XXXX-XXXX).
Implement a way to customize the pull request body
Fixes #78 Add a call to the 'clean' phase before committing changes in `PluginModernizer.java`. * Clean the target folder before committing changes if not in dry-run mode * Modify the `start` method to include the clean phase before committing, pushing, and opening a pull request --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/plugin-modernizer-tool/issues/78?shareId=XXXX-XXXX-XXXX-XXXX).
jonesbusy
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #593.
Add a call to the 'clean' phase before committing changes in
PluginModernizer.java.startmethod to include the clean phase before committing, pushing, and opening a pull requestTesting done
This created https://github.com/jenkinsci/absint-a3-plugin/pull/6/files .
Submitter checklist