Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dependency on ActiveSupport #78

Merged
merged 1 commit into from
May 2, 2018
Merged

Drop dependency on ActiveSupport #78

merged 1 commit into from
May 2, 2018

Conversation

ashmaroli
Copy link
Member

..as it will be handled by html-pipeline..

@DirtyF
Copy link
Member

DirtyF commented May 1, 2018

... https://github.com/jch/html-pipeline/blob/master/html-pipeline.gemspec#L17

@ashmaroli
Copy link
Member Author

We require at least Ruby 2.3.0.. so older versions of activesupport will be filtered out automatically..

@pathawks
Copy link
Member

pathawks commented May 1, 2018

We only started explicitly requiring activesupport in #47 because they dropped support for Ruby 2.2 but we still wanted to support it. I don't think we need to lock down the version of activesupport anymore.

@DirtyF
Copy link
Member

DirtyF commented May 2, 2018

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 3ee01c0 into jekyll:master May 2, 2018
jekyllbot added a commit that referenced this pull request May 2, 2018
@jekyllbot
Update history to reflect merge of #78 [ci skip]
017a162
@ashmaroli ashmaroli deleted the drop-dependency branch May 2, 2018 10:26
@jekyll jekyll locked and limited conversation to collaborators May 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pathawks pathawks pathawks approved these changes

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashmaroli @DirtyF @pathawks @jekyllbot