Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock activesupport down to v4.x #47

Merged
merged 1 commit into from
Jul 17, 2016
Merged

Lock activesupport down to v4.x #47

merged 1 commit into from
Jul 17, 2016

Conversation

parkr
Copy link
Member

@parkr parkr commented Jul 17, 2016 •
edited
Loading

@parkr
Copy link
Member Author

parkr commented Jul 17, 2016 •
edited
Loading

/cc @benbalter as well – activesupport v5 is causing build failures for anyone (including us) using Ruby 2.1: https://travis-ci.org/jekyll/jemoji/builds/145211270

@parkr parkr added the bug label Jul 17, 2016
@parkr
Copy link
Member Author

parkr commented Jul 17, 2016

LGTM.

@parkr
Copy link
Member Author

parkr commented Jul 17, 2016

I love that.

@parkr
Copy link
Member Author

parkr commented Jul 17, 2016

@jekyllbot: merge

@jekyllbot jekyllbot merged commit 6f818bd into master Jul 17, 2016
@jekyllbot jekyllbot deleted the activesupport-urgh branch July 17, 2016 21:24
jekyllbot added a commit that referenced this pull request Jul 17, 2016
@jekyllbot
Update history to reflect merge of #47 [ci skip]
eae73b1
@parkr parkr mentioned this pull request Jul 22, 2016
Merged
3 tasks
@pathawks pathawks mentioned this pull request May 1, 2018
Merged
@jekyll jekyll locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lock down to activesupport < 5
2 participants
@parkr @jekyllbot