Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Gemoji 3.0. #55

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Update to Gemoji 3.0. #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ rvm:
- 2.3.0
- 2.2
- 2.1
- 2.0
before_script: bundle update
script: script/cibuild
branches:
Expand Down
2 changes: 1 addition & 1 deletion jemoji.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |s|
s.add_dependency 'jekyll', '>= 3.0'
s.add_dependency 'html-pipeline', '~> 2.2'
s.add_dependency 'activesupport', '~> 4.0'
s.add_dependency 'gemoji', '~> 2.0'
s.add_dependency 'gemoji', '~> 3.0'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to allow >= 2.0, < 4.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, good point. It might create some confusion for some users, though, as then they'd have to manually upgrade gemoji themselves. But I'm down to do that if you think that's wiser. I'd be interested in @benbalter's take.

Copy link
Contributor Author

@naftulikay naftulikay Jan 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pathawks this approach makes sense to me to allow multiple versions if users want it. In my own Jekyll, I'm choosing a version for both jemoji and gemoji. Should I implement that here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the breaking change is the emoji themselves? What's the motivation for allowing 2.x?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on whether this breaks any backward compatibility. Is Gemoji 3.0 compatible with still using GitHub hosting of assets?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only curious. If there is no reason for users to be running 2.0 then this is fine 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Gemoji 3.0 compatible with still using GitHub hosting of assets?

Ahh. That'll be the question. Do you have an example of emoji not in 2 but in 3 and vise versa that we could test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since GitHub is still hosting the images, I think we're in the clear here. There may be certain emojis that GitHub isn't hosting, but IMHO that's kind of out of our control and Gemoji provides facilities for extracting images.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you all like to proceed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @parkr and @benbalter 👍

s.add_development_dependency 'rake'
s.add_development_dependency 'rdoc'
Expand Down