Update to Gemoji 3.0. #55
Conversation
|
@benbalter Travis CI failed due to Nokogiri (which I have not touched) not supporting Ruby 2.0 any more: https://travis-ci.org/jekyll/jemoji/jobs/188985491#L199 This seems to be an unrelated issue to this one. Please confirm. |
|
You can remove Ruby 2.0 from our supported Ruby versions. It should be in |
This seems to work just fine, will await Travis results. Removing Ruby 2 from the CI pipeline because Nokogiri requires at least 2.1.
|
@parkr @benbalter Ruby 2 removed from |
| @@ -12,7 +12,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency 'jekyll', '>= 3.0' | |||
| s.add_dependency 'html-pipeline', '~> 2.2' | |||
| s.add_dependency 'activesupport', '~> 4.0' | |||
| s.add_dependency 'gemoji', '~> 2.0' | |||
| s.add_dependency 'gemoji', '~> 3.0' | |||
|
|
|||
There was a problem hiding this comment.
Any reason not to allow >= 2.0, < 4.0?
There was a problem hiding this comment.
Oooh, good point. It might create some confusion for some users, though, as then they'd have to manually upgrade gemoji themselves. But I'm down to do that if you think that's wiser. I'd be interested in @benbalter's take.
There was a problem hiding this comment.
@pathawks this approach makes sense to me to allow multiple versions if users want it. In my own Jekyll, I'm choosing a version for both jemoji and gemoji. Should I implement that here?
There was a problem hiding this comment.
It looks like the breaking change is the emoji themselves? What's the motivation for allowing 2.x?
There was a problem hiding this comment.
I can't comment on whether this breaks any backward compatibility. Is Gemoji 3.0 compatible with still using GitHub hosting of assets?
There was a problem hiding this comment.
I was only curious. If there is no reason for users to be running 2.0 then this is fine 👍
There was a problem hiding this comment.
Is Gemoji 3.0 compatible with still using GitHub hosting of assets?
Ahh. That'll be the question. Do you have an example of emoji not in 2 but in 3 and vise versa that we could test?
There was a problem hiding this comment.
Since GitHub is still hosting the images, I think we're in the clear here. There may be certain emojis that GitHub isn't hosting, but IMHO that's kind of out of our control and Gemoji provides facilities for extracting images.
There was a problem hiding this comment.
How would you all like to proceed?
There was a problem hiding this comment.
I defer to @parkr and @benbalter 👍
|
GitHub is now using this library and hosting all the assets so we should be good to go! @jekyllbot: merge |
This seems to work just fine, will await Travis results.